Skip to content

Conversation

@lahinson
Copy link
Contributor

@lahinson lahinson commented Apr 14, 2025

Version(s): 4.19

Issue: https://issues.redhat.com/browse/OSDOCS-12349

Link to docs preview: https://92137--ocpdocs-pr.netlify.app/openshift-enterprise/latest/control_plane/etcd/etcd-overview

QE review:

  • QE has approved this change.

Note for reviewers: This PR adds the file and directory structure for the new, consolidated etcd section of the docs. No content is added in this PR. The content will be migrated over in separate PRs.

@lahinson lahinson added this to the Planned for 4.19 GA milestone Apr 14, 2025
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 14, 2025
@lahinson lahinson force-pushed the osdocs-12349-etcd-assembly branch from 7ab1e8e to 8d53a16 Compare April 14, 2025 18:25
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 14, 2025
@lahinson lahinson force-pushed the osdocs-12349-etcd-assembly branch 2 times, most recently from cee068b to d96bb8b Compare April 14, 2025 18:48
@lahinson lahinson changed the title [OSDOCS-12349]: Adding control_plane dir and etcd assembly [OSDOCS-12349]: Adding control_plane dir and etcd subdirectory Apr 14, 2025
@lahinson lahinson force-pushed the osdocs-12349-etcd-assembly branch from d96bb8b to 3152db7 Compare April 14, 2025 19:01
@lahinson lahinson marked this pull request as draft April 15, 2025 15:10
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2025
@lahinson lahinson force-pushed the osdocs-12349-etcd-assembly branch from 3152db7 to 02fb0a4 Compare April 15, 2025 17:16
@lahinson lahinson marked this pull request as ready for review April 15, 2025 18:25
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2025
@openshift-ci
Copy link

openshift-ci bot commented Apr 15, 2025

@lahinson: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lahinson lahinson changed the title [OSDOCS-12349]: Adding control_plane dir and etcd subdirectory [OSDOCS-12349]: Adding etcd dir and related assemblies Apr 15, 2025
@geliu2016
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2025
@lahinson lahinson added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 18, 2025
@lpettyjo lpettyjo added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 18, 2025
@lpettyjo lpettyjo self-requested a review April 18, 2025 14:38
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 18, 2025
@lahinson lahinson merged commit 84f7e54 into openshift:main Apr 18, 2025
2 checks passed
@lahinson
Copy link
Contributor Author

/cherrypick enterprise-4.19

@openshift-cherrypick-robot

@lahinson: new pull request created: #92369

Details

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.19 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants