Skip to content

OLS-1561: OLS requires secret even when RHOAI does not require token authentication #92299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

OLS-1561: OLS requires secret even when RHOAI does not require token authentication #92299

merged 1 commit into from
Apr 22, 2025

Conversation

rh-tokeefe
Copy link
Contributor

@rh-tokeefe rh-tokeefe commented Apr 16, 2025 •
edited
Loading

Affects:
lightspeed-main
lightspeed-docs-1.0tp1

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Developer Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the lightspeed-docs-1.0tp1 branch.

Version(s): TP

Issue: https://issues.redhat.com/browse/OLS-1561

Link to docs preview:
Task using CLI:
https://92299--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/configure/ols-configuring-openshift-lightspeed.html#ols-creating-lightspeed-custom-resource-file-using-cli_ols-configuring-openshift-lightspeed

Task using web console:
https://92299--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/configure/ols-configuring-openshift-lightspeed.html#ols-creating-lightspeed-custom-resource-file-using-web-console_ols-configuring-openshift-lightspeed

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 16, 2025
@rh-tokeefe rh-tokeefe changed the title Ols 1561 OLS-1561: Requires Secret Even When RHOAI Does Not Require Token Authentication Apr 16, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 16, 2025 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OLS-1561 which is a valid jira issue.

In response to this:

Affects:
lightspeed-main
lightspeed-docs-1.0tp1

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Developer Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the lightspeed-docs-1.0tp1 branch.

Version(s): TP

Issue: https://issues.redhat.com/browse/OLS-1561

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 16, 2025 •
edited
Loading

🤖 Tue Apr 22 22:39:53 - Prow CI generated the docs preview:

https://92299--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/configure/ols-configuring-openshift-lightspeed.html

@rh-tokeefe rh-tokeefe changed the title OLS-1561: Requires Secret Even When RHOAI Does Not Require Token Authentication OLS-1561: OLS requires secret even when RHOAI does not require token authentication Apr 16, 2025
@xrajesh
Copy link

xrajesh commented Apr 17, 2025

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Apr 17, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 17, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 17, 2025 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OLS-1561 which is a valid jira issue.

In response to this:

Affects:
lightspeed-main
lightspeed-docs-1.0tp1

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Developer Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the lightspeed-docs-1.0tp1 branch.

Version(s): TP

Issue: https://issues.redhat.com/browse/OLS-1561

Link to docs preview:
Task using CLI:
https://92299--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/configure/ols-configuring-openshift-lightspeed.html#ols-creating-lightspeed-custom-resource-file-using-cli_ols-configuring-openshift-lightspeed

Task using web console:
https://92299--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/configure/ols-configuring-openshift-lightspeed.html#ols-creating-lightspeed-custom-resource-file-using-web-console_ols-configuring-openshift-lightspeed

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoaoFula
Copy link
Contributor

LGTM

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2025 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OLS-1561 which is a valid jira issue.

In response to this:

Affects:
lightspeed-main
lightspeed-docs-1.0tp1

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is part of a Developer Preview release. The project is seeking feedback from early adopters.

PR must be CP'd back to the lightspeed-docs-1.0tp1 branch.

Version(s): TP

Issue: https://issues.redhat.com/browse/OLS-1561

Link to docs preview:
Task using CLI:
https://92299--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/configure/ols-configuring-openshift-lightspeed.html#ols-creating-lightspeed-custom-resource-file-using-cli_ols-configuring-openshift-lightspeed

Task using web console:
https://92299--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/configure/ols-configuring-openshift-lightspeed.html#ols-creating-lightspeed-custom-resource-file-using-web-console_ols-configuring-openshift-lightspeed

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rh-tokeefe
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 22, 2025
@lahinson lahinson added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 22, 2025
lahinson
lahinson reviewed Apr 22, 2025
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of tiny suggestions. Otherwise, LGTM for peer review.

modules/ols-creating-lightspeed-custom-resource-file-using-cli.adoc Outdated
ols:
defaultProvider: rhelai
defaultModel: models/<model_name>
additionalCAConfigMapRef:
name: openshift-service-ca.crt
----
<1> The URL endpoint must end with `v1` to be valid. For example, `\https://http://3.23.103.8:8000/v1`.
<1> By default the {rhelai} API key requires a token as part of the request. If your {rhelai} configuration does not require a token you must set the token value to any valid string for the request to authenticate.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<1> By default the {rhelai} API key requires a token as part of the request. If your {rhelai} configuration does not require a token you must set the token value to any valid string for the request to authenticate.
<1> By default, the {rhelai} API key requires a token as part of the request. If your {rhelai} configuration does not require a token, you must set the token value to any valid string for the request to authenticate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

modules/ols-creating-lightspeed-custom-resource-file-using-cli.adoc Outdated
ols:
defaultProvider: red_hat_openshift_ai
defaultModel: <model_name>
----
<1> The URL endpoint must end with `v1` to be valid. For example, `\https://<model_name>.<domain_name>.com:443/v1`.
<1> By default the {rhoai} API key requires a token as part of the request. If your {rhoai} configuration does not require a token you must set the token value to any valid string for the request to authenticate.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<1> By default the {rhoai} API key requires a token as part of the request. If your {rhoai} configuration does not require a token you must set the token value to any valid string for the request to authenticate.
<1> By default, the {rhoai} API key requires a token as part of the request. If your {rhoai} configuration does not require a token, you must set the token value to any valid string for the request to authenticate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

modules/ols-creating-lightspeed-custom-resource-file-using-web-console.adoc Outdated
ols:
defaultProvider: rhelai
defaultModel: models/<model_name>
----
<1> The URL endpoint must end with `v1` to be valid. For example, `\https://http://3.23.103.8:8000/v1`.
<1> By default the {rhelai} API key requires a token as part of the request. If your {rhelai} configuration does not require a token you must set the token value to any valid string for the request to authenticate.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<1> By default the {rhelai} API key requires a token as part of the request. If your {rhelai} configuration does not require a token you must set the token value to any valid string for the request to authenticate.
<1> By default, the {rhelai} API key requires a token as part of the request. If your {rhelai} configuration does not require a token, you must set the token value to any valid string for the request to authenticate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

modules/ols-creating-lightspeed-custom-resource-file-using-web-console.adoc Outdated
ols:
defaultProvider: red_hat_openshift_ai
defaultModel: <model_name>
----
<1> The URL endpoint must end with `v1` to be valid. For example, `\https://<model_name>.<domain_name>.com:443/v1`.
<1> By default the {rhoai} API key requires a token as part of the request. If your {rhoai} configuration does not require a token you must set the token value to any valid string for the request to authenticate.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<1> By default the {rhoai} API key requires a token as part of the request. If your {rhoai} configuration does not require a token you must set the token value to any valid string for the request to authenticate.
<1> By default, the {rhoai} API key requires a token as part of the request. If your {rhoai} configuration does not require a token, you must set the token value to any valid string for the request to authenticate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 22, 2025
@rh-tokeefe
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 22, 2025
@maxwelldb maxwelldb added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Apr 22, 2025
@maxwelldb maxwelldb added this to the Continuous Release milestone Apr 22, 2025
@maxwelldb
Copy link
Contributor

/cherry-pick lightspeed-docs-1.0tp1

@openshift-cherrypick-robot
Copy link

@maxwelldb: once the present PR merges, I will cherry-pick it on top of lightspeed-docs-1.0tp1 in a new PR and assign it to you.

In response to this:

/cherry-pick lightspeed-docs-1.0tp1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

maxwelldb
maxwelldb reviewed Apr 22, 2025
View reviewed changes
Copy link
Contributor

@maxwelldb maxwelldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor issues to address prior to merge.

@maxwelldb maxwelldb removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 22, 2025
@rh-tokeefe
Copy link
Contributor Author

@maxwelldb the changes have been pushed to the PR and the PR was squashed. Please have a look when you are back online. Thanks!

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 22, 2025

@rh-tokeefe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@maxwelldb maxwelldb merged commit 65e3934 into openshift:lightspeed-docs-main Apr 22, 2025
2 checks passed
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2025
Merged
@openshift-cherrypick-robot
Copy link

@maxwelldb: new pull request created: #92504

In response to this:

/cherry-pick lightspeed-docs-1.0tp1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrajesh xrajesh xrajesh left review comments

@lahinson lahinson lahinson left review comments

@maxwelldb maxwelldb maxwelldb approved these changes

Assignees

@xrajesh xrajesh

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
8 participants
@rh-tokeefe @openshift-ci-robot @ocpdocs-previewbot @xrajesh @JoaoFula @maxwelldb @openshift-cherrypick-robot @lahinson