Skip to content

Conversation

@DCChadwick
Copy link

@DCChadwick DCChadwick commented Apr 18, 2025

Version(s): 4.0+

Issue: OSDOCS-13571

Link to docs preview: https://92367--ocpdocs-pr.netlify.app/openshift-enterprise/latest/security/certificates/service-serving-certificate.html

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 18, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 18, 2025

@DCChadwick: This pull request references OSDOCS-13571 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.0+

Issue: OSDOCS-13571

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 18, 2025
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 18, 2025
@DCChadwick
Copy link
Author

This PR replaces #91423

@DCChadwick
Copy link
Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 18, 2025
@ocpdocs-previewbot
Copy link

@openshift-ci
Copy link

openshift-ci bot commented Apr 18, 2025

@DCChadwick: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tmalove
Copy link
Contributor

tmalove commented Apr 18, 2025

/remove-label peer-review-needed
/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 18, 2025
@tmalove
Copy link
Contributor

tmalove commented Apr 18, 2025

/remove-label peer-review-in-progress
/label peer-review-done
/lgtm

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 18, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2025
@lihongan
Copy link

lihongan commented May 6, 2025

@xingxingxia Do you know if service CA certificate owned by your team? or please help assign to proper team.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 6, 2025

@DCChadwick: This pull request references OSDOCS-13571 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.0+

Issue: OSDOCS-13571

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 6, 2025

@DCChadwick: This pull request references OSDOCS-13571 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.0+

Issue: OSDOCS-13571

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xingxingxia
Copy link
Contributor

xingxingxia commented May 7, 2025

@lihongan yes.
@DCChadwick , commented in OSDOCS-13571. Based on my test that shows everything works well without the issue, seems the doc PRs are not needed.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 7, 2025

@DCChadwick: This pull request references OSDOCS-13571 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.0+

Issue: OSDOCS-13571

Link to docs preview: https://92367--ocpdocs-pr.netlify.app/openshift-enterprise/latest/security/certificates/service-serving-certificate.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DCChadwick DCChadwick closed this May 7, 2025
@DCChadwick
Copy link
Author

This PR has been closed at QE's request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants