Skip to content

ocpbugs-45748: fixing outdated instruction #92372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: enterprise-4.14
Choose a base branch
from

Conversation

DCChadwick
Copy link

Version(s): 4.14, 4.15, 4.16, 4.17

Issue: OCPBUGS-45748

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 18, 2025
@openshift-ci-robot
Copy link

@DCChadwick: This pull request references ocpbugs-45748 which is a valid jira issue.

In response to this:

Version(s): 4.14, 4.15, 4.16, 4.17

Issue: OCPBUGS-45748

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 18, 2025
Copy link

openshift-ci bot commented Apr 18, 2025

@DCChadwick: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@DCChadwick
Copy link
Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 22, 2025
@jneczypor
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Apr 22, 2025
Copy link
Contributor

@jneczypor jneczypor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional tiny change. Otherwise, LGTM.
/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@@ -391,7 +391,7 @@ Validating and mutating admission webhooks can reject pods. If you add any addit
Alternatively, you can temporarily set the `failurePolicy` to `Ignore` while restoring the cluster state. After the cluster state is restored successfully, you can set the `failurePolicy` to `Fail`.
====

.. Remove the northbound database (nbdb) and southbound database (sbdb). Access the recovery host and the remaining control plane nodes by using Secure Shell (SSH) and run:
Remove the northbound database (nbdb) and southbound database (sbdb). Access the recovery host and the remaining nodes by using Secure Shell (SSH) and run the following command:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Remove the northbound database (nbdb) and southbound database (sbdb). Access the recovery host and the remaining nodes by using Secure Shell (SSH) and run the following command:
Remove the northbound database (nbdb) and southbound database (sbdb). Access the recovery host and the remaining nodes by using Secure Shell (SSH), and run the following command:

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants