Skip to content

OSDOCS14378: Bump ignition to spec 3.5 #92385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

mburke5678
Copy link
Contributor

@mburke5678 mburke5678 commented Apr 18, 2025

https://issues.redhat.com/browse/OSDOCS-14378

Using machine config objects to configure nodes -- Link in second paragraph
About checking machine config node status -- oc get machineconfig command output
Checking machine config node status --
Checking machine config pool status -- Steps 3 and 4 output
Machine config overview -- Link in the 9th bullet

QE review:

  • QE has approved this change.

@mburke5678 mburke5678 added this to the Planned for 4.19 GA milestone Apr 18, 2025
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 18, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 18, 2025

🤖 Thu Apr 24 12:50:12 - Prow CI generated the docs preview:
https://92385--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@mburke5678
Copy link
Contributor Author

@ptalgulk01 PTAL

@@ -8,7 +8,7 @@ toc::[]

You can use the tasks in this section to create `MachineConfig` objects that modify files, systemd unit files, and other operating system features running on {product-title} nodes. For more ideas on working with machine configs, see content related to link:https://access.redhat.com/solutions/3868301[updating] SSH authorized keys, xref:../security/container_security/security-container-signature.adoc#security-container-signature[verifying image signatures], link:https://access.redhat.com/solutions/4727321[enabling SCTP], and link:https://access.redhat.com/solutions/5170251[configuring iSCSI initiatornames] for {product-title}.

{product-title} supports link:https://coreos.github.io/ignition/configuration-v3_4/[Ignition specification version 3.4]. You should base all new machine configs you create going forward on Ignition specification version 3.4. If you are upgrading your {product-title} cluster, any existing machine configs with a previous Ignition specification will be translated automatically to specification version 3.4.
{product-title} supports link:https://coreos.github.io/ignition/configuration-v3_5/[Ignition specification version 3.4]. You should base all new machine configs you create going forward on Ignition specification version 3.5. If you are upgrading your {product-title} cluster, any existing machine configs with a previous Ignition specification will be translated automatically to specification version 3.5.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Ignition specification version 3.4] I think here it would be now [Ignition specification version 3.5]

Copy link

openshift-ci bot commented Apr 24, 2025

@mburke5678: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mburke5678 mburke5678 added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 24, 2025
@lahinson lahinson added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 24, 2025
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 24, 2025
@mburke5678 mburke5678 merged commit 830ba6b into openshift:main Apr 24, 2025
2 checks passed
@mburke5678 mburke5678 deleted the mco-bump-ignition branch April 24, 2025 14:46
@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.19

@openshift-cherrypick-robot

@mburke5678: new pull request created: #92593

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

51-master-rh-registry-trust 3.5.0 13s
51-worker-rh-registry-trust 3.5.0 53s <1>
99-master-generated-crio-seccomp-use-default 3.5.0 25m
99-master-generated-registries a2178ad522c49ee330b0033bb5cb5ea132060b0a 3.5.0 25m
99-master-ssh 3.2.0 28m
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why this is kept at 3.2.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mike-nguyen That is what I see in the output for the command. I am not sure why the 99-master-ssh and 99-worker-ssh machine configs are still at 3.2.0.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mike-nguyen @mburke5678 Hi! There is a dedicated task to perform the installer bump.
I will try to figure out the implications anytime soon, but, the first one that comes to my mind about doing the bump is (and I do not know if it's possible) what happens if the installer is used for a 4.12 OCP installation, that I repeat, I do not know if it's possible. In 4.12 we only support 3.2, so performing the bump will, for sure, break such kind of scenarios.
If the use case that I described is possible the best/safest move will be to wait for 4.12 to be totally EOL, and bump ignition to 3.4, that is supported in 4.13 and on-wards.
I will discuss this internally but, for this docs, 3.2.0 is the correct value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.19 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants