Skip to content

OSDOCS-14344: adds OTEL for AI model-server metrics MicroShift #92392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

OSDOCS-14344: adds OTEL for AI model-server metrics MicroShift #92392

merged 1 commit into from
Apr 23, 2025
+48 −2

Conversation

ShaunaDiaz
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz commented Apr 21, 2025 •
edited
Loading

Version(s):
4.19+

Issue:
OSDOCS-14344

Link to docs preview:
Adding OTEL to an InferenceService CR
Adding OTEL note to model metrics module

Reviews:

  • QE approved this change.
  • SME approved this change.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 21, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 21, 2025 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-14333 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.20" instead.

In response to this:

Version(s):
4.19+

Issue:
OSDOCS-14344

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 21, 2025
@ShaunaDiaz ShaunaDiaz added this to the Planned for 4.19 GA milestone Apr 21, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 21, 2025 •
edited
Loading

🤖 Wed Apr 23 16:59:03 - Prow CI generated the docs preview:

https://92392--ocpdocs-pr.netlify.app/microshift/latest/microshift_ai/microshift-rhoai.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 21, 2025 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-14333 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.20" instead.

In response to this:

Version(s):
4.19+

Issue:
OSDOCS-14344

Link to docs preview:
Adding OTEL to an InferenceService CR
Adding OTEL note to model metrics module

Reviews:

  • QE approved this change.
  • SME approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift openshift deleted a comment from openshift-ci-robot Apr 21, 2025
@openshift openshift deleted a comment from openshift-ci-robot Apr 21, 2025
@ShaunaDiaz ShaunaDiaz changed the title OSDOCS-14333: adds OTEL for AI model-server metrics MicroShift OSDOCS-14344: adds OTEL for AI model-server metrics MicroShift Apr 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2025 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-14344 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):
4.19+

Issue:
OSDOCS-14344

Link to docs preview:
Adding OTEL to an InferenceService CR
Adding OTEL note to model metrics module

Reviews:

  • QE approved this change.
  • SME approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pmtk
Copy link
Member

pmtk commented Apr 22, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2025 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-14344 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):
4.19+

Issue:
OSDOCS-14344

Link to docs preview:
Adding OTEL to an InferenceService CR
Adding OTEL note to model metrics module

Reviews:

  • QE approved this change.
  • SME approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agullon
Copy link

agullon commented Apr 23, 2025

/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 23, 2025 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-14344 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):
4.19+

Issue:
OSDOCS-14344

Link to docs preview:
Adding OTEL to an InferenceService CR
Adding OTEL note to model metrics module

Reviews:

  • QE approved this change.
  • SME approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShaunaDiaz ShaunaDiaz added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 23, 2025
@lahinson lahinson added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 23, 2025
lahinson
lahinson reviewed Apr 23, 2025
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few suggestions for your consideration.

@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 23, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 23, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 23, 2025

@ShaunaDiaz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ShaunaDiaz ShaunaDiaz merged commit dbdd763 into openshift:main Apr 23, 2025
2 checks passed
@ShaunaDiaz
Copy link
Contributor Author

/cherrypick enterprise-4.19

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 23, 2025
Merged
@openshift-cherrypick-robot
Copy link

@ShaunaDiaz: new pull request created: #92556

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmtk pmtk pmtk left review comments

@agullon agullon agullon left review comments

@lahinson lahinson lahinson left review comments

Assignees

@pmtk pmtk

@agullon agullon

Labels
branch/enterprise-4.19 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Planned for 4.19 GA
Development

Successfully merging this pull request may close these issues.
7 participants
@ShaunaDiaz @openshift-ci-robot @ocpdocs-previewbot @pmtk @agullon @openshift-cherrypick-robot @lahinson