-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Nodes swap memory fix 2 #92421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Nodes swap memory fix 2 #92421
Conversation
🤖 Fri Apr 25 21:32:45 - Prow CI generated the docs preview: |
modules/nodes-nodes-swap-memory.adoc
Outdated
|
||
. Enable swap memory on the machines. | ||
. Enable swap memory on the nodesS by setting the `swapaccount=1` kernel argument and configure swap memory as needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
. Enable swap memory on the nodesS by setting the `swapaccount=1` kernel argument and configure swap memory as needed. | |
. Enable swap memory on the nodes by setting the `swapaccount=1` kernel argument and configure swap memory as needed. |
|
||
* Unlimited: Use the `UnlimitedSwap` value to allow workloads to use as much swap memory as they request, up to the system limit. | ||
Regardless of the `swapBehavior` setting, any workloads that are not managed by {product-title} on that node can still use swap memory if the `failSwapOn` parameter is `false`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I'm not entirely sure what this means.
It wouldn't be possible to boot openshift if failSwapOn is true.
Any thing on the node could use swap but kubelet would not start if swap is enabled on the node.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kannon92 What I was getting at is that when you set failSwapOn: false
, whether you set swapBehavior: NoSwap
or swapBehavior: LimitedSwap
, and non-OCP workloads can use swap.
That was how I read the Kubernetes docs you suggested. (They have a nice example in system daemons, that perhaps I could add.)
/lgtm |
6053e6b
to
b5fc3c9
Compare
New changes are detected. LGTM label has been removed. |
@mburke5678: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label peer-review-in-progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/label peer-review-done |
The docs about enabling swap memory are incorrect that cgroup v2 clusters cannot use limited swap memory. It should be cgroup v1 cluster cannot use limited swap.
Also:
See the current docs: Enabling swap memory use on nodes
4.17+
Preview: Allowing swap memory use on nodes:
NoSwap
.QE review:
Related to: #92409