-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OCPBUGS-55288: Added note about bonded interface and node IP address … #92534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@dfitzmau: No Jira issue with key OCPBUGS-55288 exists in the tracker at https://issues.redhat.com/. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@dfitzmau: No Jira issue with key OCPBUGS-55288 exists in the tracker at https://issues.redhat.com/. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Fri Apr 25 11:05:13 - Prow CI generated the docs preview: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. I made a review with what the comment should look like. However, I see it is focused in baremetal IPI edge clusters, while we would need to document this for all kinds of both baremetal IPI and UPI clusters (and text might slightly change between scenarios).
So not sure if you could please move/clone the text to wherever it applies and we can then do further review.
Thanks.
modules/ipi-install-establishing-communication-between-subnets.adoc
Outdated
Show resolved
Hide resolved
31f6c85
to
d0ba02a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
At some point I think we want more explicit documentation about the two-step process that can be used in day one configuration, but for now this is better than nothing.
New changes are detected. LGTM label has been removed. |
@dfitzmau: This pull request references Jira Issue OCPBUGS-55288, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@dfitzmau: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
||
[IMPORTANT] | ||
==== | ||
During cluster installation, assign permanent IP addresses to nodes in the network configuration of the `install-config.yaml` configuration file. If you do not do this, nodes might get assigned a temporary IP address that can impact how traffic reaches the nodes. For example, if a node has a temporary IP address assigned to it and you configured a bonded interface for a node, the bonded interface might receive a different IP address. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much better now.
I'd just clarify that if this happens, node installation may never end correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @palonsoro . If any steps exist that I could embed in the docs, please let me know.
Maybe somewhere around https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html-single/installing_on_bare_metal/index#ipi-install-setting-cluster-node-hostnames-dhcp_ipi-install-installation-workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot think of concrete steps, because what you need to do is either already in the docs or out the scope of it.
Version(s):
Issue:
OCPBUGS-55228
Link to docs preview: