Skip to content

NO-JIRA: Mention Public hosted zone for HCP #92594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Apr 24, 2025

There was a typo. It should be "Public hosted zone" as can be seen in screenshot below:
image

Version(s): 4.19

Issue:

Link to docs preview: https://92594--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/hcp-deploy/hcp-deploy-aws.html#hcp-aws-create-dns-hosted-zone_hcp-deploy-aws

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 24, 2025
@openshift-ci-robot
Copy link

@mgencur: This pull request explicitly references no jira issue.

In response to this:

There was a typo. It should be "Public hosted zone" as can be seen in screenshot below:
image

Version(s): 4.19

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 24, 2025
@ocpdocs-previewbot
Copy link

🤖 Thu Apr 24 16:14:21 - Prow CI generated the docs preview:

https://92594--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/hcp-deploy/hcp-deploy-aws.html

Copy link

openshift-ci bot commented Apr 24, 2025

@mgencur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM

@lahinson lahinson added this to the Continuous Release milestone Apr 24, 2025
@lahinson lahinson merged commit 733f27b into openshift:main Apr 24, 2025
2 checks passed
@lahinson
Copy link
Contributor

/cherrypick enterprise-4.19

@lahinson
Copy link
Contributor

/cherrypick enterprise-4.18

@lahinson
Copy link
Contributor

/cherrypick enterprise-4.17

@openshift-cherrypick-robot

@lahinson: new pull request created: #92598

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@lahinson: new pull request created: #92599

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@lahinson: new pull request created: #92600

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants