Skip to content

OSSM-9338 Document Istio control plane update strategy: RevisionBased strategy #92614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jab-rh merged 1 commit into from
Jun 10, 2025
Merged

OSSM-9338 Document Istio control plane update strategy: RevisionBased strategy #92614

jab-rh merged 1 commit into from
Jun 10, 2025

Conversation

@shreyasiddhartha
Copy link
Contributor

@shreyasiddhartha shreyasiddhartha commented Apr 25, 2025 •
edited
Loading

Change type: Doc update; Document Istio control plane update strategy: RevisionBased strategy

Doc JIRA: https://issues.redhat.com/browse/OSSM-9338

Fix Version: service-mesh-docs-main and service-mesh-docs-3.0

NOTE TO THE SME and QE: This PR only covers the following sections from the docs:

  • Selecting RevisionBased strategy
  • Preparing to update Istio control plane with RevisionBased strategy
  • Updating Istio control plane with RevisionBased strategy
  • Updating Istio control plane with RevisionBased strategy and IstioRevisionTag

The next sections will be updated in the upcoming/separate PRs. The main story is: OSSM-8218

Doc Preview: https://92614--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/update/ossm-updating-openshift-service-mesh.html#select-revision-based-strategy_ossm-updating-openshift-service-mesh

SME Review/QE Review: @longmuir @FilipB @fjglira
Peer Review: @bergerhoffer

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 25, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 25, 2025 •
edited
Loading

🤖 Tue Jun 10 12:04:06 - Prow CI generated the docs preview:

https://92614--ocpdocs-pr.netlify.app/
https://92614--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/update/ossm-updating-openshift-service-mesh.html

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 6, 2025
@shreyasiddhartha
Copy link
Contributor Author

shreyasiddhartha commented May 6, 2025

/label service-mesh

@openshift-ci openshift-ci bot added the service-mesh Label for all Service Mesh PRs label May 6, 2025
@shreyasiddhartha shreyasiddhartha force-pushed the OSSM-9338 branch 2 times, most recently from 780898e to bd8d651 Compare May 6, 2025 13:28
FilipB
FilipB suggested changes May 7, 2025
View reviewed changes
fjglira
fjglira reviewed May 7, 2025
View reviewed changes
Copy link

@fjglira fjglira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some extra comments

FilipB
FilipB suggested changes May 12, 2025
View reviewed changes
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 19, 2025
fjglira
fjglira reviewed May 20, 2025
View reviewed changes
Copy link

@fjglira fjglira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, overral is Ok, but I have some comments regarding how we name the namespaces across all the docs and some comments abouts the order of the steps in some examples

@shreyasiddhartha
Copy link
Contributor Author

shreyasiddhartha commented May 21, 2025 •
edited
Loading

Hi, overral is Ok, but I have some comments regarding how we name the namespaces across all the docs and some comments abouts the order of the steps in some examples

Hey @fjglira! Will need your review again. Please give your lgtm if it's okay now.

fjglira
fjglira reviewed May 22, 2025
View reviewed changes
Copy link

@fjglira fjglira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only minor comments to update the versions that has some mismatch. Once their are changed I'll approved the PR

fjglira
fjglira approved these changes May 22, 2025
View reviewed changes
Copy link

@fjglira fjglira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shreyasiddhartha
Copy link
Contributor Author

shreyasiddhartha commented May 26, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 26, 2025
@shreyasiddhartha shreyasiddhartha force-pushed the OSSM-9338 branch 2 times, most recently from 14cf417 to 507affb Compare May 26, 2025 08:44
@bergerhoffer
Copy link
Contributor

bergerhoffer commented May 27, 2025

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 27, 2025
bergerhoffer
bergerhoffer reviewed May 27, 2025
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions and comments, let me know if you have any questions!

@bergerhoffer
Copy link
Contributor

bergerhoffer commented May 27, 2025

/label peer-review-done
/remove-label peer-review-needed
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 27, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jun 10, 2025

@shreyasiddhartha: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shreyasiddhartha
Copy link
Contributor Author

shreyasiddhartha commented Jun 10, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 10, 2025
@jab-rh jab-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jun 10, 2025
@jab-rh jab-rh merged commit 8dd700b into openshift:service-mesh-docs-main Jun 10, 2025
2 checks passed
@jab-rh
Copy link
Contributor

jab-rh commented Jun 10, 2025

/cherry-pick service-mesh-docs-3.0

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 10, 2025

@jab-rh: new pull request created: #94541

Details

In response to this:

/cherry-pick service-mesh-docs-3.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 10, 2025
Merged
@jab-rh jab-rh removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

+3 more reviewers

@FilipB FilipB FilipB requested changes

@longmuir longmuir longmuir left review comments

@fjglira fjglira fjglira approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

peer-review-done Signifies that the peer review team has reviewed this PR service-mesh Label for all Service Mesh PRs size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@shreyasiddhartha @ocpdocs-previewbot @bergerhoffer @jab-rh @openshift-cherrypick-robot @FilipB @longmuir @fjglira