-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[OSDOCS-15293] Update nw-mutual-tls-auth.adoc #96042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/retest-required |
/label peer-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hello Team, All checks have passed, and Peer review is also done. It would be really helpful if someone could please take a look and provide QE approval for this change. cc: @zhaozhanqi, @yingwang-0320, @lihongan, @rhamini3 Regards, |
- Wrong command structure in Configuring mutual TLS authentication Here is the current look: Procedure 1. In the openshift-config namespace, create a config map from your CA bundle: $ oc create configmap \ router-ca-certs-default \ --from-file=ca-bundle.pem=client-ca.crt \ 1 -n openshift-config 4. Optional, get the Distinguished Name (DN) for allowedSubjectPatterns by entering the following command. $ openssl x509 -in custom-cert.pem -noout -subject subject= /CN=example.com/ST=NC/C=US/O=Security/OU=OpenShift The above commands are not structured properly. We can use the above command as well, and it will execute perfectly. But its structure is not as per our standard procedure. Hence, it needs to be changed. Here is the updated look: 1. In the openshift-config namespace, create a config map from your CA bundle: $ oc create configmap \ router-ca-certs-default \ --from-file=ca-bundle.pem=client-ca.crt \ 1 -n openshift-config 4. Optional, get the Distinguished Name (DN) for allowedSubjectPatterns by entering the following command. $ openssl x509 -in custom-cert.pem -noout -subject subject= /CN=example.com/ST=NC/C=US/O=Security/OU=OpenShift [new-commit]Update nw-mutual-tls-auth.adoc [new-commit]Update nw-mutual-tls-auth.adoc
@prithvipatil97: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Hello @lihongan , Regards, |
/label qe-approved |
/label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
/remove-label merge-review-in-progress
/remove-label merge-review-needed
/cherrypick enterprise-4.20 |
@jeana-redhat: new pull request created: #96285 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@jeana-redhat: new pull request created: #96286 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@jeana-redhat: new pull request created: #96287 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@jeana-redhat: new pull request created: #96288 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@jeana-redhat: new pull request created: #96289 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thank you very much :) @jeana-redhat |
Here is the current look:
Procedure
Here is the updated look:
Version(s):
RHOCP 4.20, RHOCP 4.19, RHOCP 4.18, RHOCP 4.17, RHOCP 4.16
Issue:
https://issues.redhat.com/browse/OSDOCS-15293
Link to docs preview:
https://96042--ocpdocs-pr.netlify.app/openshift-dedicated/latest/networking/networking_operators/ingress-operator.html
https://96042--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/networking_operators/ingress-operator.html
https://96042--ocpdocs-pr.netlify.app/openshift-rosa/latest/networking/networking_operators/ingress-operator.html
QE review:
Additional information: