-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS 15419 CMA Automatically create KedaController during CMA Operator installation process #96337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
OSDOCS 15419 CMA Automatically create KedaController during CMA Operator installation process #96337
Conversation
@fishereskew Can you PTAL? I removed the step to create the Kobe Controller CR and made it into its own topic on editing the CR. |
@mburke5678 Lgtm! |
@prozehna PTAL |
Just the two nits that I commented on the commits themselves. Well done! |
33613fa
to
caf4528
Compare
@prozehna Thanks for the quick review. For future reference, you can review only the files on the Files changed tab. In docs, before we merge, we squash commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from few nits that needs fixing.
caf4528
to
eeb6b3a
Compare
@mburke5678: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
READY TO MERGE WHEN CUSTOM METRICS AUTOSCALER 2.17.2 RELEASES
https://issues.redhat.com/browse/OSDOCS-15419
Link to docs preview:
Installing the custom metrics autoscaler (module) -- Removed the step to create the KedaController CR. See Step 8 in current docs.
Editing the Keda Controller CR -- Converted the removed step into a new module.
Installing the custom metrics autoscaler (module) -- Removed the step to create the KedaController CR. See Step 9 in current docs.
Installing the custom metrics autoscaler (assembly) -- Modified second paragraph. New paragraph 3 and note.
QE review: