Skip to content

OSDOCS 15419 CMA Automatically create KedaController during CMA Operator installation process #96337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mburke5678
Copy link
Contributor

@mburke5678 mburke5678 commented Jul 18, 2025

READY TO MERGE WHEN CUSTOM METRICS AUTOSCALER 2.17.2 RELEASES

https://issues.redhat.com/browse/OSDOCS-15419

Link to docs preview:
Installing the custom metrics autoscaler (module) -- Removed the step to create the KedaController CR. See Step 8 in current docs.
Editing the Keda Controller CR -- Converted the removed step into a new module.
Installing the custom metrics autoscaler (module) -- Removed the step to create the KedaController CR. See Step 9 in current docs.
Installing the custom metrics autoscaler (assembly) -- Modified second paragraph. New paragraph 3 and note.

QE review:

  • QE has approved this change.

@mburke5678
Copy link
Contributor Author

@fishereskew Can you PTAL? I removed the step to create the Kobe Controller CR and made it into its own topic on editing the CR.

@fishereskew
Copy link

@mburke5678 Lgtm!

@mburke5678
Copy link
Contributor Author

@prozehna PTAL

@prozehna
Copy link
Contributor

Just the two nits that I commented on the commits themselves. Well done!

@mburke5678 mburke5678 changed the title Automatically create KedaController during CMA Operator installation process CMA Automatically create KedaController during CMA Operator installation process Jul 22, 2025
@mburke5678 mburke5678 force-pushed the podauto-cma-2172-kdea-controller branch from 33613fa to caf4528 Compare July 22, 2025 21:31
@mburke5678
Copy link
Contributor Author

@prozehna Thanks for the quick review. For future reference, you can review only the files on the Files changed tab. In docs, before we merge, we squash commits.

@mburke5678 mburke5678 added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 22, 2025
@mburke5678 mburke5678 changed the title CMA Automatically create KedaController during CMA Operator installation process OSDOCS: CMA Automatically create KedaController during CMA Operator installation process Jul 22, 2025
@mburke5678 mburke5678 changed the title OSDOCS: CMA Automatically create KedaController during CMA Operator installation process OSDOCS CMA Automatically create KedaController during CMA Operator installation process Jul 22, 2025
@mburke5678 mburke5678 changed the title OSDOCS CMA Automatically create KedaController during CMA Operator installation process OSDOCS 15419 CMA Automatically create KedaController during CMA Operator installation process Jul 22, 2025
@snarayan-redhat snarayan-redhat added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jul 23, 2025
Copy link
Contributor

@snarayan-redhat snarayan-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from few nits that needs fixing.

@snarayan-redhat snarayan-redhat removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jul 23, 2025
@mburke5678 mburke5678 force-pushed the podauto-cma-2172-kdea-controller branch from caf4528 to eeb6b3a Compare July 23, 2025 21:32
Copy link

openshift-ci bot commented Jul 23, 2025

@mburke5678: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants