OSDOCS 15419 CMA Automatically create KedaController during CMA Operator installation process #96337
+68
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/L
|
@fishereskew Can you PTAL? I removed the step to create the Kobe Controller CR and made it into its own topic on editing the CR. |
|
@mburke5678 Lgtm! |
|
@prozehna PTAL |
prozehna
reviewed
Jul 22, 2025
prozehna
reviewed
Jul 22, 2025
|
Just the two nits that I commented on the commits themselves. Well done! |
mburke5678
changed the title
mburke5678
force-pushed
the
podauto-cma-2172-kdea-controller
branch
from
33613fa to
caf4528
Compare
|
@prozehna Thanks for the quick review. For future reference, you can review only the files on the Files changed tab. In docs, before we merge, we squash commits. |
mburke5678
added
the
merge-review-needed
mburke5678
changed the title
mburke5678
changed the title
mburke5678
changed the title
snarayan-redhat
added
merge-review-in-progress
snarayan-redhat
removed
the
merge-review-in-progress
mburke5678
force-pushed
the
podauto-cma-2172-kdea-controller
branch
from
caf4528 to
eeb6b3a
Compare
|
@mburke5678: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY TO MERGE WHEN CUSTOM METRICS AUTOSCALER 2.17.2 RELEASES
https://issues.redhat.com/browse/OSDOCS-15419
Link to docs preview:
Installing the custom metrics autoscaler (module) -- Removed the step to create the KedaController CR. See Step 8 in current docs.
Editing the Keda Controller CR -- Converted the removed step into a new module.
Installing the custom metrics autoscaler (module) -- Removed the step to create the KedaController CR. See Step 9 in current docs.
Installing the custom metrics autoscaler (assembly) -- Modified second paragraph. New paragraph 3 and note.
QE review: