Skip to content

OCPBUGS-62456: netutils: Use ethtool ioctl to get permanent mac address #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: release-4.18
Choose a base branch
from
Open

OCPBUGS-62456: netutils: Use ethtool ioctl to get permanent mac address #148

wants to merge 2 commits into from

Conversation

MahnoorAsghar
Copy link

Use ethtool ioctl to get permanent MAC address in ironic-python-agent so that in case of bonded interfaces, the correct interface MAC addresses are reported
Backporting upstream fix into 4.18

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 30, 2025
@openshift-ci-robot
Copy link

@MahnoorAsghar: This pull request references Jira Issue OCPBUGS-62456, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Use ethtool ioctl to get permanent MAC address in ironic-python-agent so that in case of bonded interfaces, the correct interface MAC addresses are reported
Backporting upstream fix into 4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MahnoorAsghar
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

@MahnoorAsghar: This pull request references Jira Issue OCPBUGS-62456, which is invalid:

  • expected dependent Jira Issue OCPBUGS-62441 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@elfosardo
Copy link

/test unit

@elfosardo
Copy link

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, MahnoorAsghar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2025
kaifeng and others added 2 commits September 30, 2025 17:34
@kaifeng @MahnoorAsghar
Collect bus and driver for interfaces
c44cb23 
It's useful to have pci bus address/driver collected, the operator can
use the information to configure portgroup in a consistent way.

Change-Id: I432bca881ad881bae6d5e67c9b6fb52fe55b4e1e
(cherry picked from commit 96bf1ef)
@diconico07 @MahnoorAsghar
netutils: Use ethtool ioctl to get permanent mac address
abf0162 
Fetching the permanent MAC address of the interface instead of the
default one allows to get the right one in case it got changed during
setup (likely with a bonding setup).

In order to fetch the permanent MAC address of a given interface, one
can either use Netlink (either rtnetlink or ethtool), or use ethtool
ioctl.

The use of ioctl feels simpler and requires no additional dependency.
The implementation falls back to older behavior should an error occur.

Closes-Bug: #2103450
Change-Id: I54151990e396ddcf775128ca24d3db08e45c256d
Signed-off-by: Nicolas Belouin <[email protected]>
(cherry picked from commit 48422a5)
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 30, 2025

@MahnoorAsghar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@elfosardo
Copy link

/lgtm

@elfosardo elfosardo changed the title OCPBUGS-62456: netutils: Use ethtool ioctl to get permanent mac address OCPBUGS-62441: netutils: Use ethtool ioctl to get permanent mac address Sep 30, 2025
@openshift-ci-robot
Copy link

@MahnoorAsghar: This pull request references Jira Issue OCPBUGS-62441, which is invalid:

  • expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.z" instead
  • expected dependent Jira Issue OCPBUGS-62436 to target a version in 4.19.0, 4.19.z, but it targets "4.20.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Use ethtool ioctl to get permanent MAC address in ironic-python-agent so that in case of bonded interfaces, the correct interface MAC addresses are reported
Backporting upstream fix into 4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@elfosardo elfosardo changed the title OCPBUGS-62441: netutils: Use ethtool ioctl to get permanent mac address OCPBUGS-62456: netutils: Use ethtool ioctl to get permanent mac address Sep 30, 2025
@openshift-ci-robot
Copy link

@MahnoorAsghar: This pull request references Jira Issue OCPBUGS-62456, which is invalid:

  • expected dependent Jira Issue OCPBUGS-62441 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Use ethtool ioctl to get permanent MAC address in ironic-python-agent so that in case of bonded interfaces, the correct interface MAC addresses are reported
Backporting upstream fix into 4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@elfosardo
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elfosardo elfosardo Awaiting requested review from elfosardo

@iurygregory iurygregory Awaiting requested review from iurygregory

Assignees

@elfosardo elfosardo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MahnoorAsghar @openshift-ci-robot @elfosardo @kaifeng @diconico07