Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] TRT-1286: List images from external binary #29450

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] TRT-1286: List images from external binary #29450

wants to merge 1 commit into from

Conversation

bertinatto
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 17, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2025 •
edited by openshift-ci bot
Loading

@bertinatto: This pull request references TRT-1286 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from p0lyn0mial and sjenning January 17, 2025 20:13
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2025
@bertinatto bertinatto force-pushed the list-images-external-test-binary branch from f00f784 to 4394648 Compare January 18, 2025 00:24
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 18, 2025

@bertinatto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn 4394648 link false /test e2e-metal-ipi-ovn
ci/prow/e2e-agnostic-ovn-cmd 4394648 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-metal-ipi-ovn-ipv6 4394648 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-gcp-ovn-upgrade 4394648 link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 4394648 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/verify 4394648 link true /test verify
ci/prow/e2e-aws-ovn-serial 4394648 link true /test e2e-aws-ovn-serial
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout 4394648 link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-single-node-serial 4394648 link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt openshift-trt
Copy link

openshift-trt bot commented Jan 18, 2025

Job Failure Risk Analysis for sha: 4394648

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial Medium
[sig-imageregistry][Serial] Image signature workflow can push a signed image to openshift registry and verify it [apigroup:user.openshift.io][apigroup:image.openshift.io] [Skipped:Disconnected] [Suite:openshift/conformance/serial]
This test has passed 97.10% of 241 runs on release 4.19 [Overall] in the last week.
pull-ci-openshift-origin-master-e2e-aws-ovn-serial Medium
[sig-imageregistry][Serial] Image signature workflow can push a signed image to openshift registry and verify it [apigroup:user.openshift.io][apigroup:image.openshift.io] [Skipped:Disconnected] [Suite:openshift/conformance/serial]
This test has passed 97.10% of 241 runs on release 4.19 [Overall] in the last week.

stbenjam
stbenjam reviewed Jan 24, 2025
View reviewed changes
pkg/cmd/openshift-tests/images/images_command.go
Comment on lines +182 to +185
if len(imagesFromExternalBinaries) > 0 {
// FIXME: only 1 for now
initialDefaults = imagesFromExternalBinaries[0]
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be better if we could gather up all the external image binaries here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stbenjam stbenjam stbenjam left review comments

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

@sjenning sjenning Awaiting requested review from sjenning

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bertinatto @openshift-ci-robot @stbenjam