Skip to content

ci: Enable more kola tests for SCOS #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 11, 2022

Conversation

travier
Copy link
Member

@travier travier commented Jul 21, 2022

Includes temporary workarounds for variant selection for non default
variants. Will be removed once COSA support for variants is completed.


el9: Re-enable /tmp on tmpfs

See: https://gitlab.com/redhat/centos-stream/rpms/systemd/-/blob/c9s/0004-Avoid-tmp-being-mounted-as-tmpfs-without-the-user-s-.patch
See: https://gitlab.com/redhat/centos-stream/rpms/systemd/-/commit/9efbb443aa9f8de751926cd903f9c56806d85972#b9c1ef0bb10dd8f850e36759e92628f539183e73


el9: Remove dbus-broker workaround


tests: Use new toolbox test


c9s: Disable iscsid.socket


denylist: Use versioned kola denylists


scos: Skip (currently) broken kola tests


ci: Remove disabled test and add instructions

Fixes: #937


ci: Enable more kola tests for SCOS

@openshift-ci openshift-ci bot requested review from jlebon and ravanelli July 21, 2022 09:03
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2022
@travier travier force-pushed the scos-ci2 branch 2 times, most recently from 8122d3c to 4766226 Compare July 21, 2022 11:13
@cgwalters
Copy link
Member

Looks like CI is failing on extensions...we could perhaps disable that? Or dive into figuring out the virt module and rhel9

@travier
Copy link
Member Author

travier commented Jul 22, 2022

I could not find kata-containers in RHEL 9 (might have not looked in the right place). Will reach out to them.

@travier
Copy link
Member Author

travier commented Jul 22, 2022

SCOS is now hitting kola test failures cc @HuijingHei
RHCOS is blocked on rhel-9-fast-datapath repo which has the wrong URL apparently.

@HuijingHei
Copy link
Contributor

SCOS is now hitting kola test failures

Thanks @travier for the report, will look more about the failure

@HuijingHei
Copy link
Contributor

For the scos pxe-install failed, create #909 to track

@cgwalters
Copy link
Member

Might make sense to:

  • change the CI config to avoid testing the things that are broken
  • merge this PR to avoid any further regressions, and enable shipping e.g. registry.ci.openshift.org/rhcos-devel/rhel-coreos-9:latest
  • track things like kola PXE testing as separate issues

@travier
Copy link
Member Author

travier commented Jul 26, 2022

I'm looking for the correct URL for this repo but have not found it yet:

Updating metadata for 'rhel-9-fast-datapath'...done
�[0m�[31merror: �[0mUpdating rpm-md repo 'rhel-9-fast-datapath': cannot update repo 'rhel-9-fast-datapath': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried; Last error: Status code: 404 for http://base-4-12-rhel90.ocp.svc.cluster.local/rhel-9-fast-datapath/repodata/repomd.xml (IP: 172.30.115.61)

To be changed in https://github.com/openshift/release/blob/master/core-services/release-controller/_repos/ocp-4.12-rhel90.repo

@HuijingHei
Copy link
Contributor

/test scos-9-build-test-qemu

@travier
Copy link
Member Author

travier commented Jul 28, 2022

openshift/release#30894 should unblock RHEL 9.0

@cgwalters
Copy link
Member

rhel-9-fast-datapath

fast-datapath is as I understand things in a "netherworld" between OpenShift and OpenStack - both of which use openvswitch. It is technically not RHEL. As I understand it also, perhaps because OpenShift is leading OpenStack here in pushing for RHEL9, we're the first to hit its absence.

I tried a while ago to escalate this with their managers but didn't get any traction. Now that it's closer to the blocking path, seems that we should try again.

OTOH...RHCOS only ships openvswitch on the host because the networking team pushed hard for it - but it certainly can be run in a container. I would definitely like to revisit that discussion. In that case, we can just ship the RHEL8 openvswitch in a container!

@dcbw
Copy link
Contributor

dcbw commented Jul 28, 2022

@cgwalters I'm not sure what the ask is here... we're very unlikely to revisit the decision to ship OVS on the host.

Is the problem that something isn't connecting the RHEL9 fast-datapath repos into the RHCOS structure? If that's a problem we can certainly fix that...

@travier
Copy link
Member Author

travier commented Jul 28, 2022

@cgwalters The openvswitch packages exists for RHEL 9. I had made a mistake in the repo URL which is fixed in openshift/release#30894.

@cgwalters
Copy link
Member

we're very unlikely to revisit the decision to ship OVS on the host.

😢

@HuijingHei
Copy link
Contributor

/retest

@HuijingHei
Copy link
Contributor

rhcos-90-build-test-metal failed error: Packages not found: skopeo >= 2:1.7.0
will be fixed by #921

@travier travier force-pushed the scos-ci2 branch 3 times, most recently from f05ca58 to 93446fc Compare July 29, 2022 11:07
@travier
Copy link
Member Author

travier commented Aug 8, 2022

/retest

@travier travier force-pushed the scos-ci2 branch 3 times, most recently from 35e737d to ba01f6d Compare August 9, 2022 12:33
@travier travier changed the title ci: Enable full CI for SCOS (with failing tests excluded) ci: Enable more kola tests for SCOS Aug 9, 2022
@travier
Copy link
Member Author

travier commented Aug 9, 2022

/unhold

Making this one just for kola testing of SCOS.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2022
@travier
Copy link
Member Author

travier commented Aug 10, 2022

/test ci/prow/scos-9-build-test-qemu

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2022

@travier: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test images
  • /test periodic-images
  • /test rhcos-86-build-test-metal
  • /test rhcos-86-build-test-qemu
  • /test rhcos-90-build-test-metal
  • /test rhcos-90-build-test-qemu
  • /test scos-9-build-test-metal
  • /test scos-9-build-test-qemu
  • /test validate

Use /test all to run all jobs.

In response to this:

/test ci/prow/scos-9-build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier
Copy link
Member Author

travier commented Aug 10, 2022

/test scos-9-build-test-qemu

@travier
Copy link
Member Author

travier commented Aug 11, 2022

🎉

@lucab
Copy link
Contributor

lucab commented Aug 11, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, lucab, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cgwalters,lucab,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2022

@travier: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 38fd416 into openshift:master Aug 11, 2022
@travier travier deleted the scos-ci2 branch August 11, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants