Skip to content

Use latest pre-commit hooks with python3.12 for 18.0-fr4 #71993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2025
Merged

Use latest pre-commit hooks with python3.12 for 18.0-fr4 #71993

merged 1 commit into from
Dec 2, 2025

Conversation

@rabi
Copy link
Contributor

@rabi rabi commented Dec 1, 2025 •
edited
Loading

No description provided.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2025
@openshift-ci openshift-ci bot requested review from slagle and stuggi December 1, 2025 04:45
@rabi
Copy link
Contributor Author

rabi commented Dec 1, 2025

/pj-rehearse pull-ci-openstack-k8s-operators-edpm-ansible-main-pre-commit-test

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 1, 2025

@rabi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rabi
Copy link
Contributor Author

rabi commented Dec 1, 2025

/pj-rehearse pull-ci-openstack-k8s-operators-edpm-ansible-main-pre-commit-test

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 1, 2025

@rabi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rabi
Copy link
Contributor Author

rabi commented Dec 1, 2025

/pj-rehearse pull-ci-openstack-k8s-operators-edpm-ansible-main-pre-commit-test

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 1, 2025

@rabi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rabi
Copy link
Contributor Author

rabi commented Dec 1, 2025

/pj-rehearse pull-ci-openstack-k8s-operators-edpm-ansible-main-pre-commit-test

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 1, 2025

@rabi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rabi
Copy link
Contributor Author

rabi commented Dec 1, 2025

/pj-rehearse pull-ci-openstack-k8s-operators-edpm-ansible-main-pre-commit-test

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 1, 2025

@rabi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rabi rabi marked this pull request as draft December 1, 2025 07:32
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2025
@rabi
Copy link
Contributor Author

rabi commented Dec 2, 2025

/pj-rehearse pull-ci-openstack-k8s-operators-edpm-ansible-main-pre-commit-test

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 2, 2025

@rabi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rabi
Copy link
Contributor Author

rabi commented Dec 2, 2025

/pj-rehearse pull-ci-openstack-k8s-operators-edpm-ansible-main-pre-commit-test

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 2, 2025

@rabi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rabi rabi changed the title Use centos-stream base image Use latest pre-commit hooks with python3.12 for 18.0-fr4 Dec 2, 2025
@rabi
Copy link
Contributor Author

rabi commented Dec 2, 2025

/pj-rehearse pull-ci-openstack-k8s-operators-edpm-ansible-main-pre-commit-test

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 2, 2025

@rabi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 2, 2025

[REHEARSALNOTIFIER]
@rabi: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openstack-k8s-operators-edpm-ansible-18.0-fr4-images openstack-k8s-operators/edpm-ansible presubmit Presubmit changed
pull-ci-openstack-k8s-operators-edpm-ansible-main-images openstack-k8s-operators/edpm-ansible presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-edpm-ansible-main-pre-commit-test openstack-k8s-operators/edpm-ansible presubmit Ci-operator config changed
pull-ci-openstack-k8s-operators-edpm-ansible-18.0-fr4-pre-commit-test openstack-k8s-operators/edpm-ansible presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@rabi
Copy link
Contributor Author

rabi commented Dec 2, 2025

/pj-rehearse pull-ci-openstack-k8s-operators-edpm-ansible-main-pre-commit-test

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 2, 2025

@rabi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rabi rabi marked this pull request as ready for review December 2, 2025 05:23
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2025
@openshift-ci openshift-ci bot requested review from dprince and rebtoor December 2, 2025 05:24
@rabi
Copy link
Contributor Author

rabi commented Dec 2, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 2, 2025

@rabi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 2, 2025
stuggi
stuggi approved these changes Dec 2, 2025
View reviewed changes
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rabi, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8cf5c9f into openshift:master Dec 2, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slagle slagle Awaiting requested review from slagle

@dprince dprince Awaiting requested review from dprince

@rebtoor rebtoor Awaiting requested review from rebtoor

1 more reviewer

@stuggi stuggi stuggi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@stuggi stuggi

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rabi @openshift-ci-robot @stuggi