-
Notifications
You must be signed in to change notification settings - Fork 95
Add Component Readiness dashboard for Cluster Observability Operator (COO) #3109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Pipeline controller notification For optional jobs, comment |
WalkthroughAdds the layered-product identifier Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: IshwarKanse The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
config/views.yaml (1)
1521-1522: Consider enabling prime_cache for better dashboard performance.The
prime_cachesetting is disabled (enabled: false), while similar component readiness configurations like4.21-main(line 81),4.20-main(line 490), and4.19-main(line 961) have it enabled.Prime caching improves dashboard load times. Unless there's a specific reason to disable it for COO (e.g., this is experimental), consider setting it to
trueonce the dashboard is stable.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (4)
config/views.yaml(1 hunks)pkg/db/suites.go(1 hunks)pkg/variantregistry/ocp.go(1 hunks)pkg/variantregistry/snapshot.yaml(10 hunks)
🔇 Additional comments (4)
pkg/db/suites.go (1)
70-70: LGTM! Suite addition follows established pattern.The addition of "COO-lp-interop" is consistent with other layered product test suites already in the list.
pkg/variantregistry/ocp.go (1)
1107-1107: LGTM! Pattern mapping is consistent with other layered products.The "-coo-" pattern correctly identifies COO jobs and maps them to the "lp-interop-coo" variant, consistent with the job names listed in the PR description (e.g.,
periodic-ci-rhobs-observability-operator-main-*-coo-stage).config/views.yaml (1)
1479-1522: Verify the minimal configuration scope for the COO dashboard.The new
coo-component-readinessconfiguration looks structurally correct and follows established patterns. However, there are a few scope considerations to verify:
Release coverage: The configuration tracks releases 4.18→4.19, but the PR description mentions 10 COO jobs spanning OCP versions 4.12 through 4.19. Is the intention to start with 4.18→4.19 and expand later, or should there be additional configurations for other release pairs?
Minimal variant filtering: The
include_variantssection is quite minimal compared to other component readiness configurations:
- Only includes Architecture and Platform in
column_group_by(lines 1489-1491)- Only includes Architecture, Platform, and Suite in
db_group_by(lines 1492-1495)- Doesn't specify Network, Topology, Installer, FeatureSet variants in
include_variantsThis minimal approach may be intentional for a new dashboard, but please confirm this matches your requirements.
Suite handling: Suite is included in
db_group_by(line 1495) but not explicitly filtered ininclude_variants. This means all suite values will be included, which may be correct for COO jobs.pkg/variantregistry/snapshot.yaml (1)
238329-238545: Snapshot regeneration is correct and properly reflects the COO layered product mapping.The "-coo-" pattern mapping is confirmed in
pkg/variantregistry/ocp.go(line 1107):{"-coo-", "lp-interop-coo"}. All 10 job entries in the diff contain this pattern and are correctly assignedLayeredProduct: lp-interop-coo. The snapshot generation logic insnapshot.goand the test inocp_test.goconfirm this is auto-generated and properly validated. The changes are valid.
|
Scheduling required tests: |
|
@IshwarKanse I think you need to update ci-test-mapping suites first similar to ci-test-mapping#501 |
ac9b023 to
468c460
Compare
@neisw Added the COO mapping to testSuites. openshift-eng/ci-test-mapping#531 |
|
/test ci/prow/security |
|
@IshwarKanse: The specified target(s) for Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test security |
|
Scheduling required tests: |
…(COO) Assisted using Claude Code.
468c460 to
3a99abc
Compare
|
Scheduling required tests: |
|
/test e2e |
|
@IshwarKanse: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@neisw Fixed the existing typo issue reported by coderabbit and updated the 4.19 view. |
Add Component Readiness dashboards for Cluster Observability Operator (COO)
Overview
This PR adds support for tracking Component Readiness for the Cluster Observability Operator (COO) as a separate layered product dashboard. COO consists of a number of components and we need a similar dashboard as OpenShift core to track the readiness for the components.
Component Readiness views are added for COO across actively supported OCP versions (4.16-4.21).
Changes
Configuration Views (
config/views.yaml)Added Component Readiness views for COO across OCP versions:
All views are configured with:
lp-interop-cooga-30dtogafor GA'd releasesSuite Registration (
pkg/db/suites.go)COO-lp-interopto the test suites listOpenshitPipelines-lp-interop→OpenshiftPipelines-lp-interopVariant Registry (
pkg/variantregistry/ocp.go)-coo-are tagged as LayeredProductlp-interop-cooSnapshot (
pkg/variantregistry/snapshot.yaml)lp-interop-cooRelated Jobs
This tracks the following COO periodic jobs:
Testing
{OCP_RELEASE}-lp-Interop-{product}