[WIP] New Implicit Muscle (vandenBogert) #1160
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Need to tests Jacobians yet.
…bleshooting (temporary)
…ensim-core into vandenBogertMuscle
…ensim-core into vandenBogertMuscle
Merge branch 'master' of https://github.com/opensim-org/opensim-core into vandenBogertMuscle Conflicts: Bindings/simbody.i
…into vandenBogertMuscle
This commit depends on a change in Simbody that is only on my computer!
|
|
||
| SimTK::Vector upper_bounds(2); | ||
| upper_bounds[0] = SimTK::Infinity; | ||
| upper_bounds[1] = SimTK::Infinity; |
There was a problem hiding this comment.
It should be straightforward to compute the maximum/minimum values of adot. And the maximum/minimum values of fiber velocity could maybe be taken from the max_contraction_velocity property (I don't remember the exact name).
…ngth. Some doxygen cleanup.
…d other cache variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work In Process. This muscle has Implicit Dynamics.
This PR is for the muscle only. The files of interest are:
See @chrisdembia's PR #1147 for the implicit components implementation (I had merged his branch with mine so they are inadvertently both contained here).
This change is