Skip to content

Fix lifecycle contributor state accounting and add extra QA for sqlmesh metrics pipeline #5177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Fix lifecycle contributor state accounting and add extra QA for sqlmesh metrics pipeline #5177

wants to merge 9 commits into from

Conversation

@kenyiu
Copy link
Member

@kenyiu kenyiu commented Sep 26, 2025

FIx this: #2186 (comment)

@kenyiu kenyiu temporarily deployed to external-prs-app September 26, 2025 15:45 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Sep 26, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
kariba-network Ready Ready Preview Comment Oct 25, 2025 3:42pm
oso-www Ready Ready Preview Comment Oct 25, 2025 3:42pm

ccerv1
ccerv1 reviewed Sep 27, 2025
View reviewed changes
Copy link
Member

@ccerv1 ccerv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between a "first time" contributor and a "new" contributor?

I believe we already have "new" contributors working, right?

@kenyiu
Copy link
Member Author

kenyiu commented Sep 27, 2025

For the logic of new contributor now, its relying on the author_association provided by github. There are a few issues for using it:

  1. It will be removed: https://github.blog/changelog/2025-08-08-upcoming-changes-to-github-events-api-payloads/#whats-changing
  2. The logic now is only considering first pr as new contributor, which seems not fitting our updated scenarios

Then, i used the label name proposed in your table without rewriting the new_contributor one, but we can definitely update the one.

@kenyiu kenyiu temporarily deployed to external-prs-app October 3, 2025 17:08 — with GitHub Actions Inactive
@kenyiu kenyiu temporarily deployed to external-prs-app October 3, 2025 17:13 — with GitHub Actions Inactive
@kenyiu kenyiu temporarily deployed to external-prs-app October 4, 2025 01:14 — with GitHub Actions Inactive
@kenyiu kenyiu temporarily deployed to external-prs-app October 18, 2025 12:59 — with GitHub Actions Inactive
@kenyiu kenyiu temporarily deployed to external-prs-app October 24, 2025 14:08 — with GitHub Actions Inactive
@kenyiu
refactor(metrics): rename new_contributors -> first_time_contributors…
a9ff086 
… and update related logic/tests

- Rename metric identifiers in SQL: lifecycle.sql now uses first_time_* (aliases, churn calc, and change_in fields)
- Update tests to reference first_time_contributors_* and change_in_first_time_contributors_*
- Remove obsolete bot_activity periodic test fixtures (monthly/quarterly/biannually)
- metrics_factories: remove early skip for new_contributors so first-time metrics are audited
- factory: adjust ignored incremental rule to first_time_contributors and tidy MetricsCycle error message formatting
@kenyiu kenyiu temporarily deployed to external-prs-app October 25, 2025 15:41 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ccerv1 ccerv1 ccerv1 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenyiu @ccerv1