Skip to content

fixed navbar links #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityai0 merged 4 commits into from
Jul 23, 2025
Merged

fixed navbar links #102

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25db490
fixed navbar links
pbln Jul 23, 2025
bcad60f
fixing all the navigation links
pbln Jul 23, 2025
a958b13
all links fixed
pbln Jul 23, 2025
9992a68
Update index.html
pbln Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@
<nav class="header__nav" id="navMenu">
<ul class="nav__list">
<li><a href="/" data-route="/" class="nav__link">Home</a></li>
<li><a href="/challenges" data-route="/challenges" class="nav__link active">Challenges</a></li>
<li><a href="editor.html" data-route="/editor" class="nav__link">Editor</a></li>
<li><a href="/profile" data-route="/profile" class="nav__link">Profile</a></li>
<li><a href="about.html" class="nav__link">About</a></li>
<li><a href="pages/challenges.html" data-route="/challenges" class="nav__link active">Challenges</a></li>
<li><a href="pages/editor.html" data-route="/editor" class="nav__link">Editor</a></li>
<li><a href="pages/profile.html" data-route="/profile" class="nav__link">Profile</a></li>
<li><a href="pages/about.html" class="nav__link">About</a></li>
Copy link
Contributor

@greptile-apps greptile-apps bot Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: These href changes break the client-side routing system. The router in app.js expects href attributes to match the data-route values for proper navigation interception.

</ul>
</nav>
<button class="header__toggle" id="navToggle" aria-label="Open navigation menu">
Expand Down Expand Up @@ -109,8 +109,8 @@ <h4>CodeClip</h4>
<h4>Quick Links</h4>
<ul>
<li><a href="/" data-route="/">Home</a></li>
<li><a href="/challenges" data-route="/challenges">Challenges</a></li>
<li><a href="/editor" data-route="/editor">Editor</a></li>
<li><a href="pages/challenges.html" data-route="/challenges">Challenges</a></li>
<li><a href="pages/editor.html" data-route="/editor">Editor</a></li>
</ul>
</div>
<div class="footer__section">
Expand Down