Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion index.html
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,6 @@ <h3 class="secHeader"><span>About</span> CodeClip</h3>
</div>
</div>
</section>
<!-- ================================ About Section End Here ================================ -->

<!-- ================================ Footer Section Start Here ================================ -->
<footer id="contactFooter">
Expand Down
27 changes: 14 additions & 13 deletions pages/about.html
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

<!-- Styles -->
<!-- If you want to keep all challenge styles in one file, use: -->
<link rel="stylesheet" href="../styles.css">
<link rel="stylesheet" href="/CodeClip/styles/about.css">
<!-- Or, if you want to scope styles to just challenges, use: -->
<!-- <link rel="stylesheet" href="../styles/challenges.css" /> -->
</head>
Expand All @@ -28,11 +28,12 @@
</div>
<nav class="header__nav" id="navMenu">
<ul class="nav__list">
<li><a href="/" data-route="/" class="nav__link">Home</a></li>
<li><a href="challenges.html" data-route="/challenges" class="nav__link active">Challenges</a></li>
<li><a href="editor.html" data-route="/editor" class="nav__link">Editor</a></li>
<li><a href="profile.html" data-route="/profile" class="nav__link">Profile</a></li>
<li><a href="about.html" class="nav__link">About</a></li>
<li><a href="index.html" data-route="/" class="nav__link">Home</a></li>
<li><a href="challenges.html" data-route="/challenges" class="nav__link active">Challenges</a></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Challenges nav link marked as active on about page - should be the About link instead

Suggested change
<li><a href="challenges.html" data-route="/challenges" class="nav__link active">Challenges</a></li>
<li><a href="challenges.html" data-route="/challenges" class="nav__link">Challenges</a></li>

<li><a href="editor.html" data-route="/editor" class="nav__link">Editor</a></li>
<li><a href="profile.html" data-route="/profile" class="nav__link">Profile</a></li>
<li><a href="about.html" class="nav__link">About</a></li>

</ul>
</nav>
<button class="header__toggle" id="navToggle" aria-label="Open navigation menu">
Expand Down Expand Up @@ -78,9 +79,10 @@ <h4>CodeClip</h4>
<div class="footer__section">
<h4>Quick Links</h4>
<ul>
<li><a href="/" data-route="/">Home</a></li>
<li><a href="challenges.html" data-route="/challenges">Challenges</a></li>
<li><a href="editor.html" data-route="/editor">Editor</a></li>
<li><a href="index.html" data-route="/">Home</a></li>
<li><a href="challenges.html" data-route="/challenges">Challenges</a></li>
<li><a href="editor.html" data-route="/editor">Editor</a></li>

</ul>
</div>
<div class="footer__section">
Expand All @@ -105,10 +107,9 @@ <h4>Community</h4>
</button>

<!-- Scripts -->
<script type="module" src="../scripts/app.js"></script>
<script type="module" src="../scripts/theme.js"></script>
<script src="../scripts/challenges.js"></script>

<script type="module" src="app.js"></script>
<script type="module" src="theme.js"></script>
<script src="challenges.js"></script>
Comment on lines +110 to +112
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Script paths removed '../' prefix but files are in ../scripts/ directory - these will fail to load

Suggested change
<script type="module" src="app.js"></script>
<script type="module" src="theme.js"></script>
<script src="challenges.js"></script>
<script type="module" src="../scripts/app.js"></script>
<script type="module" src="../scripts/theme.js"></script>
<script src="../scripts/challenges.js"></script>

<style>
/* Additional styles for challenges page */
.challenges-hero {
Expand Down
450 changes: 163 additions & 287 deletions pages/challenges.html

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions pages/editor.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/[email protected]/font/bootstrap-icons.min.css">
<!-- Prism.js CSS for syntax highlighting -->
<link href="https://cdn.jsdelivr.net/npm/[email protected]/themes/prism-tomorrow.min.css" rel="stylesheet" />

<style>
/* Custom CSS Variables for the new theme */
:root {
Expand Down Expand Up @@ -121,10 +121,10 @@
<div style="display: flex; align-items: center; gap: 2rem;">
<div style="font-size: 1.5rem; font-weight: 700; color: #4FC3F7;">CodeClip</div>
<nav style="display: flex; gap: 1.5rem;">
<a href="/" data-route="/" style="color: #f8f9fa; text-decoration: none; padding: 0.5rem 1rem; border-radius: 0.5rem; transition: background 0.2s;">Home</a>
<a href="challenges.html" data-route="/challenges" style="color: #f8f9fa; text-decoration: none; padding: 0.5rem 1rem; border-radius: 0.5rem; transition: background 0.2s;">Challenges</a>
<a href="editor.html" data-route="/editor" style="color: #4FC3F7; text-decoration: none; padding: 0.5rem 1rem; border-radius: 0.5rem; background: rgba(79, 195, 247, 0.1);">Editor</a>
<a href="profile.html" data-route="/profile" style="color: #f8f9fa; text-decoration: none; padding: 0.5rem 1rem; border-radius: 0.5rem; transition: background 0.2s;">Profile</a>
<a href="/CodeClip" style="color: #f8f9fa; text-decoration: none; padding: 0.5rem 1rem; border-radius: 0.5rem; transition: background 0.2s;">Home</a>
<a href="/CodeClip/pages/challenges.html" style="color: #f8f9fa; text-decoration: none; padding: 0.5rem 1rem; border-radius: 0.5rem; transition: background 0.2s;">Challenges</a>
<a href="/CodeClip/pages/editor.html" style="color: #4FC3F7; text-decoration: none; padding: 0.5rem 1rem; border-radius: 0.5rem; background: rgba(79, 195, 247, 0.1);">Editor</a>
<a href="/CodeClip/pages/profile.html" style="color: #f8f9fa; text-decoration: none; padding: 0.5rem 1rem; border-radius: 0.5rem; transition: background 0.2s;">Profile</a>
Comment on lines +124 to +127
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Navigation links removed data-route attributes that were required for SPA routing. The router in app.js expects these attributes to handle client-side navigation.

Suggested change
<a href="/CodeClip" style="color: #f8f9fa; text-decoration: none; padding: 0.5rem 1rem; border-radius: 0.5rem; transition: background 0.2s;">Home</a>
<a href="/CodeClip/pages/challenges.html" style="color: #f8f9fa; text-decoration: none; padding: 0.5rem 1rem; border-radius: 0.5rem; transition: background 0.2s;">Challenges</a>
<a href="/CodeClip/pages/editor.html" style="color: #4FC3F7; text-decoration: none; padding: 0.5rem 1rem; border-radius: 0.5rem; background: rgba(79, 195, 247, 0.1);">Editor</a>
<a href="/CodeClip/pages/profile.html" style="color: #f8f9fa; text-decoration: none; padding: 0.5rem 1rem; border-radius: 0.5rem; transition: background 0.2s;">Profile</a>
<a href="/CodeClip" data-route="/" style="color: #f8f9fa; text-decoration: none; padding: 0.5rem 1rem; border-radius: 0.5rem; transition: background 0.2s;">Home</a>
<a href="/CodeClip/pages/challenges.html" data-route="/challenges" style="color: #f8f9fa; text-decoration: none; padding: 0.5rem 1rem; border-radius: 0.5rem; transition: background 0.2s;">Challenges</a>
<a href="/CodeClip/pages/editor.html" data-route="/editor" style="color: #4FC3F7; text-decoration: none; padding: 0.5rem 1rem; border-radius: 0.5rem; background: rgba(79, 195, 247, 0.1);">Editor</a>
<a href="/CodeClip/pages/profile.html" data-route="/profile" style="color: #f8f9fa; text-decoration: none; padding: 0.5rem 1rem; border-radius: 0.5rem; transition: background 0.2s;">Profile</a>

</nav>
</div>
<div>
Expand Down
12 changes: 6 additions & 6 deletions pages/profile.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
<link href="https://fonts.googleapis.com/css2?family=Bitcount:[email protected]&family=Oooh+Baby&display=swap" rel="stylesheet">

<!-- Styles -->
<link rel="stylesheet" href="../styles.css">
<link rel="stylesheet" href="/styles/profile.css">
<link rel="stylesheet" href="/CodeClip/styles.css">
<link rel="stylesheet" href="..\styles\profile.css">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: Inconsistent path separator - uses backslashes instead of forward slashes like line 15. Should be ../styles/profile.css

Suggested change
<link rel="stylesheet" href="..\styles\profile.css">
<link rel="stylesheet" href="../styles/profile.css">


<script src="https://cdn.jsdelivr.net/npm/chart.js"></script>

Expand All @@ -27,10 +27,10 @@
</div>
<nav class="header__nav" id="navMenu">
<ul class="nav__list">
<li><a href="/" data-route="/" class="nav__link">Home</a></li>
<li><a href="challenges.html" data-route="/challenges" class="nav__link">Challenges</a></li>
<li><a href="editor.html" data-route="/editor" class="nav__link">Editor</a></li>
<li><a href="profile.html" data-route="/profile" class="nav__link active">Profile</a></li>
<li><a href="/CodeClip/index.html" class="nav__link">Home</a></li>
<li><a href="/CodeClip/pages/challenges.html" class="nav__link">Challenges</a></li>
<li><a href="/CodeClip/pages/editor.html" class="nav__link">Editor</a></li>
<li><a href="/CodeClip/pages/profile.html" class="nav__link active">Profile</a></li>
</ul>
</nav>
<button class="header__toggle" id="navToggle" aria-label="Open navigation menu">
Expand Down
Loading
Loading