Skip to content

fix the styling of the challenges card #issue 131 #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chilaka-eswari wants to merge 1 commit into from
Closed

fix the styling of the challenges card #issue 131 #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pages/challenges.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ <h2 id="filters-heading" class="visually-hidden">Filter Challenges</h2>
placeholder="Search challenges..."
aria-label="Search coding challenges by title or tag"
/>
<button id="clearFilters" class="btn btn-secondary">Clear Filters</button>
<button id="clearFilters" class="clear_btn btn-secondary">Clear Filters</button>
</div>
</div>
</section>
Expand Down
19 changes: 17 additions & 2 deletions styles/challenges.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,19 @@ body {
box-shadow: 0 0 6px var(--accent-color-hover);
}

.clearFilters{
border: none;
border-radius: 0.5rem;
padding: 0.55rem 1.1rem;
font-size: 0.9rem;
font-weight: 700;
cursor: pointer;
text-decoration: none;
display: inline-block;
transition: background-color 0.3s ease;
user-select: none;

}
Comment on lines +222 to +234
Copy link
Contributor

@greptile-apps greptile-apps bot Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing background-color property makes button invisible. Add background-color: var(--accent-color);

Suggested change
.clearFilters{
border: none;
border-radius: 0.5rem;
padding: 0.55rem 1.1rem;
font-size: 0.9rem;
font-weight: 700;
cursor: pointer;
text-decoration: none;
display: inline-block;
transition: background-color 0.3s ease;
user-select: none;
}
.clearFilters{
border: none;
border-radius: 0.5rem;
padding: 0.55rem 1.1rem;
font-size: 0.9rem;
font-weight: 700;
cursor: pointer;
text-decoration: none;
display: inline-block;
transition: background-color 0.3s ease;
user-select: none;
background-color: var(--accent-color);
color: white;
}

/* === CHALLENGES GRID === */
.challenges-grid {
padding: 3rem 0 5rem;
Expand Down Expand Up @@ -293,7 +306,7 @@ body {
flex-grow: 1;
font-size: 1rem;
line-height: 1.4;
color: #555;
color: #f9f8f8;
margin-bottom: 1rem;
}

Expand All @@ -316,6 +329,7 @@ body {

.challenge-card__actions {
text-align: right;
color:white
Copy link
Contributor

@greptile-apps greptile-apps bot Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: Missing semicolon and hardcoded color breaks theming. Use var(--text-color)

Suggested change
color:white
color: var(--text-color);

}

.btn {
Expand All @@ -329,10 +343,11 @@ body {
display: inline-block;
transition: background-color 0.3s ease;
user-select: none;
color: white;
Copy link
Contributor

@greptile-apps greptile-apps bot Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Redundant color declaration since .btn-primary already sets white color

}

.btn-sm {
font-size: 0.85rem;
font-size: 0.90rem;
padding: 0.4rem 0.8rem;
}

Expand Down
Loading