Add: my feature Fixed Hover color for GitHub & Discord icons in dark mode

[Ayesha1209s]

Description:

This PR fixes #727 an inconsistency where the GitHub and Discord icons were not applying the correct hover color in dark mode. While all icons turned green on hover in light mode, GitHub and Discord remained with the default dark background in dark mode.

Changes Made:

• Added explicit dark mode hover styles for .social-link elements.
• Ensured GitHub and Discord icons correctly change to the green hover color (var(--primary-500)) in dark mode.

Code Changes:

[data-theme='dark'] .social-link:hover {
background-color: var(--primary-500);
color: white;
}

Steps to Test:

1-Switch to dark mode.
2-Hover over GitHub and Discord icons.
3-Verify that the hover color now changes to green, consistent with light mode.

Before clip-------

beforclip.mp4

After clip-------

After_clip.mp4

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[github-actions]

Thanks for submitting your first pull request to the Open Source Society project — we really appreciate your contribution! Our maintainers will review your PR soon. In the meantime, make sure you've followed the contribution checklist and linked any relevant issues. Welcome aboard, and keep contributing! 💚

[Ayesha1209s]

you can check i have fixed this issue

[FrostByte-49]

[data-theme='dark'] .social-link {
  background-color: rgba(255, 255, 255, 0.1);
}

Hey @Ayesha1209s,
Could you please re-add these lines of code? Removing them causes the button background to blend with the footer background. It’s better to have a slightly different background for the button than the footer. The hover background you’ve added looks good, so no need to change that.
Thank You!

[Ayesha1209s]

Hey @FrostByte-49 ,
Got it, I’ll re-add the base background for .social-link and keep the hover effect as it is.

[FrostByte-49]

Looks good to me! Thanks for updating this, really appreciate your effort 😊

[Harsh-26626]

@Ayesha1209s Can you sync changes from master branch and then make your changes (footer hover effect) and raise another PR?

We merge PRs only in master for review purposes (check #485 ) We'll merge these changes if everything goes well with master later:)

[Ayesha1209s]

Hey @Harsh-26626 ,
yeah suree

[Ayesha1209s]

Hi @Harsh-26626
I synced with the repo, but I only see main (no master branch exists)

[Harsh-26626]

@Ayesha1209s you'll have to create a new branch, name it master and then select source repo as opensource-society/notesvault. Also set source branch as master! (See image)

After that raise a new pull request by implementing changes in master branch.

Your new PR must target the master branch.

After that mention new pull request number here:)

[Ayesha1209s]

Hi @Harsh-26626 👋,
I’ve now synced the my-feature branch into my fork’s master and created a new PR: “Pull Request from master branch – UI Fixes #783 targeting opensource-society/notesvault:master.
This should meet the requirement you mentioned. Please review and let me know if anything else is needed 🙂