Skip to content

Conversation

@Gourangi4
Copy link

Issue Fixed: #765

What changed

  • Replaced hard-coded “Welcome Back” with neutral “Welcome to NotesVault” for logged-out users.
  • Added JS check using localStorage keys nv_user and nv_user_name.
  • CTA logic:
    • Logged out → “Sign Up” (href: signup.html)
    • Logged in → “Upload Notes” (href: upload.html), greeting “Welcome back, ” when available.

Why
Prevents confusing message for first-time/logged-out users; improves onboarding clarity.

How I tested

  1. Incognito / cleared storage → shows “Welcome to NotesVault” + “Sign Up”.
  2. Console:
    localStorage.setItem('nv_user','1');
    localStorage.setItem('nv_user_name','Gourangi');
    location.reload();
image → shows “Welcome back, Gourangi” + “Upload Notes”.

localStorage.removeItem('nv_user');
localStorage.removeItem('nv_user_name');
location.reload();

image → returns to logged-out state.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting your first pull request to the Open Source Society project — we really appreciate your contribution! Our maintainers will review your PR soon. In the meantime, make sure you've followed the contribution checklist and linked any relevant issues. Welcome aboard, and keep contributing! 💚

@OpArcade OpArcade added the level 1 Beginner-level issue label Aug 26, 2025
@Gourangi4
Copy link
Author

hey @adityai0 , kindly check the pr I have submitted.

@adityai0 adityai0 merged commit c6913f1 into opensource-society:main Aug 30, 2025
1 check passed
@adityai0 adityai0 added the gssoc2025 This issue is part of GirlScript Summer of Code 2025 label Aug 30, 2025
@Gourangi4 Gourangi4 deleted the issue-765-welcome-back-fix branch August 30, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc2025 This issue is part of GirlScript Summer of Code 2025 level 1 Beginner-level issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants