ovn: Use charmcraft 2.x for branch 22.03 #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freyes
requested changes
Jan 27, 2026
Member
There was a problem hiding this comment.
we should probably switch these other stable charms to 2.x too, agree?
Author
There was a problem hiding this comment.
I'll defer to your judgement here. But on the surface, yeah it seems like a good idea. It will certainly spare us the surprising build failures in the future if we decide that we need to re-build some of these older branches.
Author
There was a problem hiding this comment.
Would you like me to bump all of them (including those on 1.5), or just those that are currently pinned to 2.1?
We would like to switch to `reactive` plugin in charmcraft, instead of manually executing "charm-build" command in `override-build`. As a result we need to use charmcraft<=2.1. Signed-off-by: Martin Kalcok <[email protected]>
mkalcok
force-pushed
the
ovn-22.03-charmcraft
branch
from
13ac607 to
5caba84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to switch to
reactiveplugin in charmcraft, instead of manually executing "charm-build" command inoverride-build. As a result we need to use charmcraft<=2.1.