Skip to content

Enable Octavia in dt template for scalelab #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
asyedham wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enable Octavia in dt template for scalelab #667

asyedham wants to merge 2 commits into from
+437 −0

Conversation

@asyedham
Copy link

@asyedham asyedham commented Dec 8, 2025

No description provided.

@openshift-ci
Copy link

openshift-ci bot commented Dec 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asyedham
Once this PR has been reviewed and has the lgtm label, please assign abays for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Dec 8, 2025

Hi @asyedham. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

abays
abays reviewed Dec 8, 2025
View reviewed changes
dt/perfscale/scalelab/kustomization.yaml
kind: OpenStackControlPlane
fieldPaths:
- spec.octavia.template.octaviaWorker.customServiceConfig
options:
Copy link
Contributor

@abays abays Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These customServiceConfig values are missing from the example service-values.yaml [1].

[1] https://github.com/openstack-k8s-operators/architecture/pull/667/files#diff-b7716c2bc8911e1df09aefc07234bb25b20d80e87dae23e3416b96c95790c0f2R64-R79

Copy link
Contributor

@abays abays Dec 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, meant to select L263-309

Copy link
Author

@asyedham asyedham Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@abays
Copy link
Contributor

abays commented Dec 8, 2025

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abays abays abays left review comments

@karelyatin karelyatin Awaiting requested review from karelyatin

@leifmadsen leifmadsen Awaiting requested review from leifmadsen

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asyedham @abays