Skip to content

Adjust Adoption OSP Deploy to use ipv4 or ipv6 #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ciecierski
Copy link
Contributor

@ciecierski ciecierski commented May 14, 2025

Currently ipv4 is the only supported protocol for initial OSP17 deployment. With this change based on cifmw_networking_env_definition file network version protocol is detected and used for generating network related files.

Resolves: OSPRH-16510

@ciecierski ciecierski requested a review from a team as a code owner May 14, 2025 09:47
Copy link
Contributor

openshift-ci bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/725aa689ecb24c34a817a2130181581a

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 51m 32s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 14m 30s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 34m 47s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 35s
cifmw-pod-pre-commit FAILURE in 8m 10s
✔️ build-push-container-cifmw-client SUCCESS in 18m 22s
✔️ cifmw-molecule-adoption_osp_deploy SUCCESS in 2m 51s

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently ipv4 is the only supported protocol for initial OSP17 deployment.
With this change based on cifmw_networking_env_definition file network version
protocol is detected and used for generating network related files.
@ciecierski ciecierski force-pushed the config_files_ipv6 branch from 897f2ff to 09d81ab Compare May 16, 2025 10:57
- ip_netmask: {{ net.ip_v4 }}/{{ net.prefix_length_v4 }}
- ip_netmask: {{ net.ip_v4.split('.')[:3] | join('.') }}.2/32
- ip_netmask: {{ net[ip_version|default('ip_v4')] }}/{{ net[prefix_length_version|default('prefix_length_v4')] }}
- ip_netmask: {{ net[ip_version|default('ip_v4')].split('.')[:3] | join('.') }}.2/32
Copy link
Contributor

@fyanac fyanac May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it has a mask /32 for ipv4, I guess it needs /128 for ipv6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants