-
Notifications
You must be signed in to change notification settings - Fork 126
Adjust Adoption OSP Deploy to use ipv4 or ipv6 #2983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adjust Adoption OSP Deploy to use ipv4 or ipv6 #2983
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/725aa689ecb24c34a817a2130181581a ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 51m 32s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line13 - address for ipv6, it should be 128, no 32. It could be like this: https://gitlab.cee.redhat.com/eng/openstack/tripleo-ansible/-/blob/rhos-18.0-trunk-patches/tripleo_ansible/roles/tripleo_network_config/templates/undercloud.j2?ref_type=heads#L4-13
Currently ipv4 is the only supported protocol for initial OSP17 deployment. With this change based on cifmw_networking_env_definition file network version protocol is detected and used for generating network related files.
897f2ff
to
09d81ab
Compare
- ip_netmask: {{ net.ip_v4 }}/{{ net.prefix_length_v4 }} | ||
- ip_netmask: {{ net.ip_v4.split('.')[:3] | join('.') }}.2/32 | ||
- ip_netmask: {{ net[ip_version|default('ip_v4')] }}/{{ net[prefix_length_version|default('prefix_length_v4')] }} | ||
- ip_netmask: {{ net[ip_version|default('ip_v4')].split('.')[:3] | join('.') }}.2/32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it has a mask /32 for ipv4, I guess it needs /128 for ipv6
Currently ipv4 is the only supported protocol for initial OSP17 deployment. With this change based on cifmw_networking_env_definition file network version protocol is detected and used for generating network related files.
Resolves: OSPRH-16510