Skip to content

[repo_setup] Add cifmw_repo_setup_venv var #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

raukadah
Copy link
Contributor

@raukadah raukadah commented May 15, 2025

Currently repo-setup gets installed with {{ cifmw_repo_setup_basedir }}/venv. This venv is shared with other roles. Dependencies coming from different repo causes issue with repo-setup.

Currently ansible-core deps installed via ci-framework gets used in repo-setup causes following issue:

 HTTPSConnection.__init__() got an unexpected keyword argument 'cert_file'. Failed to create HashInfo object

Updating ansible-core will fix the issue but it may cause issue with other ci-framework roles.

In order to avoid that, we are adding a seperate var to create seperate venv to keep repo-setup dependency seperate and avoid issues.

Jira: OSPRH-16694

@raukadah raukadah requested a review from a team as a code owner May 15, 2025 04:57
Copy link
Contributor

openshift-ci bot commented May 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

evallesp
evallesp previously approved these changes May 15, 2025
Copy link
Contributor

@evallesp evallesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Currently repo-setup gets installed with {{ cifmw_repo_setup_basedir
}}/venv. This venv is shared with other roles. Dependencies coming
from different repo causes issue with repo-setup.

Currently ansible-core deps installed via ci-framework gets used in
repo-setup causes following issue:
```
 HTTPSConnection.__init__() got an unexpected keyword argument 'cert_file'. Failed to create HashInfo object
```

Updating ansible-core will fix the issue but it may cause issue with
other ci-framework roles.

In order to avoid that, we are adding a seperate var to create
seperate venv to keep repo-setup dependency seperate and avoid
issues.

Jira: OSPRH-16694

Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6e6d563aa9e14f478d294d7adefed2ca

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 51m 14s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 48s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 42m 10s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT Host unreachable in 2h 36m 29s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 06s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 49s
✔️ build-push-container-cifmw-client SUCCESS in 18m 08s
✔️ cifmw-molecule-build_openstack_packages SUCCESS in 10m 57s
✔️ cifmw-molecule-repo_setup SUCCESS in 4m 45s

@raukadah
Copy link
Contributor Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ec2d48d81be24b11a24d5c3dfc401cfa

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 48m 00s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 42s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 33m 47s
adoption-standalone-to-crc-ceph-provider FAILURE in 1h 33m 47s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 16s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 57s
✔️ build-push-container-cifmw-client SUCCESS in 21m 19s
✔️ cifmw-molecule-build_openstack_packages SUCCESS in 11m 48s
✔️ cifmw-molecule-repo_setup SUCCESS in 4m 39s

@raukadah
Copy link
Contributor Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/66940f7ebdfd4bb7aa8534777fb9fde9

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 45m 05s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 10m 13s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 30m 19s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 11m 27s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 59s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 13s
✔️ build-push-container-cifmw-client SUCCESS in 21m 29s
✔️ cifmw-molecule-build_openstack_packages SUCCESS in 12m 02s
✔️ cifmw-molecule-repo_setup SUCCESS in 4m 41s

@raukadah
Copy link
Contributor Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4521a215476c4514baf6314902fe7c15

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 53m 13s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 09m 46s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 39m 09s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT Host unreachable in 2h 38m 12s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 55s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 18s
✔️ build-push-container-cifmw-client SUCCESS in 21m 11s
✔️ cifmw-molecule-build_openstack_packages SUCCESS in 10m 09s
✔️ cifmw-molecule-repo_setup SUCCESS in 4m 27s

@dasm
Copy link
Contributor

dasm commented May 19, 2025

@raukadah I'm not sure if that's the best way to solve the problem. Have you tried updating ansible-core? Adding extra venv is gonna create another layer of problems.

@raukadah
Copy link
Contributor Author

@raukadah I'm not sure if that's the best way to solve the problem. Have you tried updating ansible-core? Adding extra venv is gonna create another layer of problems.

Thank you for the review @dasm , We explored the path of bumping ansible-core and it does solves the issues if you check the attached jira. Since ansiblec-core is the common requirements for ci-framework. It may break other roles that's why we did not went via that route.

@danpawlik
Copy link
Contributor

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5b6e9a9cba424a468556bb6ac1047300

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 29m 31s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 38s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 38m 00s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 14m 34s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 28s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 44s
✔️ build-push-container-cifmw-client SUCCESS in 23m 28s
cifmw-molecule-build_openstack_packages FAILURE in 6m 19s
✔️ cifmw-molecule-repo_setup SUCCESS in 4m 43s

@raukadah
Copy link
Contributor Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/40960920f8d04cf3b63b001cfde94ef0

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 20m 34s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 58s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 41m 13s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 06m 18s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 27s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 17s
✔️ build-push-container-cifmw-client SUCCESS in 17m 48s
cifmw-molecule-build_openstack_packages FAILURE in 6m 11s
✔️ cifmw-molecule-repo_setup SUCCESS in 4m 39s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants