-
Notifications
You must be signed in to change notification settings - Fork 125
[repo_setup] Add cifmw_repo_setup_venv var #2988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Currently repo-setup gets installed with {{ cifmw_repo_setup_basedir }}/venv. This venv is shared with other roles. Dependencies coming from different repo causes issue with repo-setup. Currently ansible-core deps installed via ci-framework gets used in repo-setup causes following issue: ``` HTTPSConnection.__init__() got an unexpected keyword argument 'cert_file'. Failed to create HashInfo object ``` Updating ansible-core will fix the issue but it may cause issue with other ci-framework roles. In order to avoid that, we are adding a seperate var to create seperate venv to keep repo-setup dependency seperate and avoid issues. Jira: OSPRH-16694 Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6e6d563aa9e14f478d294d7adefed2ca ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 51m 14s |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ec2d48d81be24b11a24d5c3dfc401cfa ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 48m 00s |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/66940f7ebdfd4bb7aa8534777fb9fde9 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 45m 05s |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4521a215476c4514baf6314902fe7c15 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 53m 13s |
@raukadah I'm not sure if that's the best way to solve the problem. Have you tried updating |
Thank you for the review @dasm , We explored the path of bumping ansible-core and it does solves the issues if you check the attached jira. Since ansiblec-core is the common requirements for ci-framework. It may break other roles that's why we did not went via that route. |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5b6e9a9cba424a468556bb6ac1047300 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 29m 31s |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/40960920f8d04cf3b63b001cfde94ef0 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 20m 34s |
Currently repo-setup gets installed with {{ cifmw_repo_setup_basedir }}/venv. This venv is shared with other roles. Dependencies coming from different repo causes issue with repo-setup.
Currently ansible-core deps installed via ci-framework gets used in repo-setup causes following issue:
Updating ansible-core will fix the issue but it may cause issue with other ci-framework roles.
In order to avoid that, we are adding a seperate var to create seperate venv to keep repo-setup dependency seperate and avoid issues.
Jira: OSPRH-16694