Reduce retry count for iscsi login #3006
Conversation
In a previous PR, we added custom login timeout values in the iscsid.conf file[1]. However, even with reduced values (from 120 seconds to 15 seconds), we still see failures in CI jobs due to timeout. To further improve the situation, we can set the retry count to 1 making the wait time 5 seconds which should be sufficient to pass the tempest wait threshold (and we shouldn't really need to retry in jobs anyway). CIX: https://issues.redhat.com/browse/OSPCIX-805 [1] openstack-k8s-operators#2060
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -9,7 +9,7 @@ | |||
| path: /etc/iscsi/iscsid.conf | |||
| line: "{{ item }}" | |||
| loop: | |||
| - 'node.session.initial_login_retry_max = 3' | |||
| - 'node.session.initial_login_retry_max = 1' | |||
There was a problem hiding this comment.
That's true but even if you look at the successful login attempts, even 1 second is enough, we are being very generous to give 5
May 19 21:58:34 compute-y9ihgosq-1 nova_compute[73665]: 2025-05-19 16:28:34.166 134 DEBUG oslo_concurrency.processutils [-] CMD "iscsiadm -m node -T iqn.1992-08.com.netapp:sn.1b60aa2ba3ab11e8911600a098d00ab0:vs.5 -p 10.46.246.75:3260 --login" returned: 0 in 0.030s execute /usr/lib/python3.9/site-packages/oslo_concurrency/processutils.py:422
May 19 21:58:34 compute-y9ihgosq-1 nova_compute[73665]: 2025-05-19 16:28:34.168 134 DEBUG oslo_concurrency.processutils [-] CMD "iscsiadm -m node -T iqn.1992-08.com.netapp:sn.1b60aa2ba3ab11e8911600a098d00ab0:vs.5 -p 10.46.246.74:3260 --login" returned: 0 in 0.033s execute /usr/lib/python3.9/site-packages/oslo_concurrency/processutils.py:422
In a previous PR, we added custom login timeout values in the iscsid.conf file[1].
However, even with reduced values (from 120 seconds to 15 seconds), we still see failures in CI jobs due to timeout.
To further improve the situation, we can set the retry count to 1 making the wait time 5 seconds which should be sufficient to pass the tempest wait threshold (and we shouldn't really need to retry in jobs anyway).
CIX: https://issues.redhat.com/browse/OSPCIX-805
[1] #2060