Skip to content

Configure adoption_ironic_post_oc subnet with ipv6 #3358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Configure adoption_ironic_post_oc subnet with ipv6 #3358

wants to merge 1 commit into from
+10 −0

Conversation

abhibongale
Copy link

@abhibongale abhibongale commented Oct 1, 2025 •
edited by hjensas
Loading

We have noticed that uni04delta-ipv6 adoption deploys the OSP17.1 successfully with IPv6 network. But we found out that ironic subnet is configured with IPv4 instead of IPv6.

This PR aims to fix it.

fixes: OSPRH-20019

@abhibongale
adoption_ironic_post_oc configure subnet with ipv6
1a28a6d 
We have noticed that uni04delta-ipv6 adoption deploys the OSP17.1
successfully with IPv6 network. But we found out that ironic subnet
is configured with IPv4 instead of IPv6. This PR aims to fix it.

fixes: OSPRH-20019
Signed-off-by: Abhishek Bongale <[email protected]>
@abhibongale abhibongale self-assigned this Oct 1, 2025
@abhibongale abhibongale requested a review from a team as a code owner October 1, 2025 10:02
@abhibongale abhibongale requested a review from hjensas October 1, 2025 10:02
@hjensas
Copy link
Contributor

hjensas commented Oct 1, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 1, 2025
@hjensas hjensas enabled auto-merge (rebase) October 1, 2025 13:03
@abhibongale abhibongale mentioned this pull request Oct 1, 2025
Open
abhibongale added a commit to abhibongale/data-plane-adoption that referenced this pull request Oct 1, 2025
@abhibongale
[OSPRH-20017] Enable Ironic in uni04delta-ipv6
a8c062e 
Goal is to have CI automation in uni04delta-ipv6 data plane adoption
scenario to configure Ironic IPv6 in OSP17.1 cloud that is deployed.

It partially solves the OSPRH-20019

Depends-On: openstack-k8s-operators/ci-framework#3358

fixes: OSRPH-20017, OSPRH-20019
Signed-off-by: Abhishek Bongale <[email protected]>
juliakreger
juliakreger reviewed Oct 1, 2025
View reviewed changes
Copy link
Contributor

@juliakreger juliakreger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: juliakreger

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

abhibongale added a commit to abhibongale/data-plane-adoption that referenced this pull request Oct 1, 2025
@abhibongale
[OSPRH-20017] Enable Ironic in uni04delta-ipv6
9b8a962 
Goal is to have CI automation in uni04delta-ipv6 data plane adoption
scenario to configure Ironic IPv6 in OSP17.1 cloud that is deployed.

It partially solves the OSPRH-20019

Depends-On: openstack-k8s-operators/ci-framework#3358

fixes: OSRPH-20017, OSPRH-20019
Signed-off-by: Abhishek Bongale <[email protected]>
abhibongale added a commit to abhibongale/data-plane-adoption that referenced this pull request Oct 1, 2025
@abhibongale
[OSPRH-20017] Enable Ironic in uni04delta-ipv6
778a953 
Goal is to have CI automation in uni04delta-ipv6 data plane adoption
scenario to configure Ironic IPv6 in OSP17.1 cloud that is deployed.

It partially solves the OSPRH-20019

Depends-On: openstack-k8s-operators/ci-framework#3358

fixes: OSRPH-20017, OSPRH-20019
Signed-off-by: Abhishek Bongale <[email protected]>
abhibongale added a commit to abhibongale/data-plane-adoption that referenced this pull request Oct 1, 2025
@abhibongale
[OSPRH-20017] Enable Ironic in uni04delta-ipv6
a20f225 
Goal is to have CI automation in uni04delta-ipv6 data plane adoption
scenario to configure Ironic IPv6 in OSP17.1 cloud that is deployed.

It partially solves the OSPRH-20019

Depends-On: openstack-k8s-operators/ci-framework#3358

fixes: OSRPH-20017, OSPRH-20019
Signed-off-by: Abhishek Bongale <[email protected]>
abhibongale added a commit to abhibongale/data-plane-adoption that referenced this pull request Oct 1, 2025
@abhibongale
[OSPRH-20017] Enable Ironic in uni04delta-ipv6
5af4cac 
Goal is to have CI automation in uni04delta-ipv6 data plane adoption
scenario to configure Ironic IPv6 in OSP17.1 cloud that is deployed.

It partially solves the OSPRH-20019

Depends-On: openstack-k8s-operators/ci-framework#3358

fixes: OSRPH-20017, OSPRH-20019
Signed-off-by: Abhishek Bongale <[email protected]>
abhibongale added a commit to abhibongale/data-plane-adoption that referenced this pull request Oct 1, 2025
@abhibongale
[OSPRH-20017] Enable Ironic in uni04delta-ipv6
b441035 
Goal is to have CI automation in uni04delta-ipv6 data plane adoption
scenario to configure Ironic IPv6 in OSP17.1 cloud that is deployed.

It partially solves the OSPRH-20019

Depends-On: openstack-k8s-operators/ci-framework#3358

fixes: OSRPH-20017, OSPRH-20019
Signed-off-by: Abhishek Bongale <[email protected]>
abhibongale added a commit to abhibongale/data-plane-adoption that referenced this pull request Oct 1, 2025
@abhibongale
[OSPRH-20017] Enable Ironic in uni04delta-ipv6
1b30d1f 
Goal is to have CI automation in uni04delta-ipv6 data plane adoption
scenario to configure Ironic IPv6 in OSP17.1 cloud that is deployed.

It partially solves the OSPRH-20019

Depends-On: openstack-k8s-operators/ci-framework#3358

fixes: OSRPH-20017, OSPRH-20019
Signed-off-by: Abhishek Bongale <[email protected]>
hjensas
hjensas reviewed Oct 1, 2025
View reviewed changes
Copy link
Contributor

@hjensas hjensas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hjensas
Copy link
Contributor

hjensas commented Oct 1, 2025

TestProject successful: https://gitlab.cee.redhat.com/ci-framework/ci-framework-testproject/-/merge_requests/1563#note_18125703

Hook ran without errors, see log: https://sf.apps.int.gpc.ocp-hub.prod.psi.redhat.com/logs/575/components-integration/5754e692a77a4df4807d2ddf17b8df2b/logs/controller/ci-framework-data/logs/ci_script_000_run_hook_without_retry_ironic.log

@danpawlik
Copy link
Contributor

if you can update commit message:

Configure adoption_ironic_post_oc  subnet with ipv6

We have noticed that uni04delta-ipv6 adoption deploys the OSP17.1
successfully with IPv6 network, but we found out that ironic subnet
is configured with IPv4 instead of IPv6. 
This commit aims to fix it.

@hjensas hjensas changed the title adoption_ironic_post_oc configure subnet with ipv6 Configure adoption_ironic_post_oc subnet with ipv6 Oct 2, 2025
@hjensas
Copy link
Contributor

hjensas commented Oct 2, 2025

if you can update commit message:

Configure adoption_ironic_post_oc  subnet with ipv6

We have noticed that uni04delta-ipv6 adoption deploys the OSP17.1
successfully with IPv6 network, but we found out that ironic subnet
is configured with IPv4 instead of IPv6. 
This commit aims to fix it.

@danpawlik I update the PR description. @abhibongale left for PTO for 3-4 weeks, is it ok? Otherwize I guess it's a fetch for this PR, ammend the commit and create a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjensas hjensas hjensas left review comments

@juliakreger juliakreger juliakreger left review comments

@evallesp evallesp evallesp approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@hjensas hjensas

@abhibongale abhibongale

Labels
lgtm ok-to-test Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abhibongale @hjensas @danpawlik @juliakreger @evallesp