-
Notifications
You must be signed in to change notification settings - Fork 141
[cleanup_openstack] enhance cleanup for infrastructure reuse #3473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7eaaa34d066444eba0136148611369dc ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 35m 57s |
@eshulman2 (I deleted the previous comment because I completely misunderstood your question, sorry Ella 🙇🏻 ) BTW I want to keep use that role, i just tried to address some aspects:
I don't know if all of this will lead to a bulletproof procedure but i heard some feedback about the reliability of this cleanup procedure and i'd like to improve it. Any kind of suggestion is more than welcome though! |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/384b0a9282964a6cad26847d17890532 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 48m 02s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/689e395593904c7180a66b83f187edee ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 41m 30s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d0f82689056044bab35e7d66f2f7c30d ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 46m 37s |
16471c0 to
bf9b991
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/131597c22c9049c281ec693790095b54 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 05s |
ef442aa to
83afa3d
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6749298792164c1fb3eb416ca5225304 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 05s |
9e69945 to
4c165a3
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b3ec10b2d1a7422fa7d8c07688c95ce9 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 02m 14s |
3b167c0 to
5eb6395
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f4912b3fb2504f81ac9d4f641b59ba0d ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 59m 19s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c6470bc393114be49ba8941116273aa5 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 46m 50s |
Enable OpenStack cleanup while preserving cluster infrastructure for faster CI test cycles without full reprovisioning between runs. Fixes critical bugs: - Undefined variables (cifmw_basedir, kubeconfig) - Inconsistent kubeconfig usage across tasks - Missing result checks before accessing module outputs - Dry-run mode bypasses and variable scope issues - Infrastructure operators deletion (preserved for reuse) Adds production features: - Dry-run mode and selective cleanup via tags - Comprehensive cleanup summary and verification - Self-contained role with proper fallback chains New task files: cleanup_crs_direct, cleanup_openstack_api, cleanup_storage, cleanup_namespaces, common. New playbook: cleanup-openstack-for-reuse.yml. Includes documentation and Ansible Galaxy metadata. Assisted-By: claude-4.5-sonnet Closes: OSPRH-21759 Signed-off-by: Roberto Alfieri <[email protected]>
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e0497c15e28749f1949466118affd33f ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 48m 54s |
|
This PR is stale because it has been for over 15 days with no activity. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Enhance the cleanup_openstack role to support infrastructure reuse by
cleaning up OpenStack resources while preserving the OpenShift cluster
infrastructure. This enables faster test cycles by avoiding full
infrastructure reprovisioning.
Changes:
networks, volumes, etc.) before CR deletion to prevent orphaned resources
is still running, then CRs are deleted
Assisted-By: Cursor AI Assistant
Related: OSPRH-21759