Skip to content

Conversation

@slagle
Copy link
Contributor

@slagle slagle commented Nov 24, 2025

When generate_bm_info.yml runs on controller-0, it needs access to
_cifmw_libvirt_manager_layout to determine the correct boot_mode based
on the VM's uefi configuration. Since configure_controller.yml uses
delegate_facts: false, the layout fact wasn't available on controller-0,
causing boot_mode to always default to 'legacy' even for UEFI VMs.

This fix explicitly passes the layout from the hypervisor's hostvars
to make it available for the delegated tasks, ensuring VMs with nvram
are correctly identified as UEFI boot mode in baremetal-info.yml.

Also fixes the regex in reproducer/tasks/generate_bm_info.yml to set the
_type var and match hostnames that are like:
cifmw-compute-wcl4866c-0

Assisted-By: Claude
Jira: OSPRH-22373
Signed-off-by: James Slagle [email protected]

…e detection

When generate_bm_info.yml runs on controller-0, it needs access to
_cifmw_libvirt_manager_layout to determine the correct boot_mode based
on the VM's uefi configuration. Since configure_controller.yml uses
delegate_facts: false, the layout fact wasn't available on controller-0,
causing boot_mode to always default to 'legacy' even for UEFI VMs.

This fix explicitly passes the layout from the hypervisor's hostvars
to make it available for the delegated tasks, ensuring VMs with nvram
are correctly identified as UEFI boot mode in baremetal-info.yml.

Also fixes the regex in reproducer/tasks/generate_bm_info.yml to set the
_type var and match hostnames that are like:
cifmw-compute-wcl4866c-0

Assisted-By: Claude
Jira: OSPRH-22373
Signed-off-by: James Slagle <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dasm for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d20d9b3d7dd240bcac895548b95aa84f

openstack-k8s-operators-content-provider FAILURE in 11m 50s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 35s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 56s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 59s
✔️ build-push-container-cifmw-client SUCCESS in 19m 12s
✔️ cifmw-molecule-reproducer SUCCESS in 16m 12s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant