Skip to content

Conversation

ratailor
Copy link
Contributor

@ratailor ratailor commented Sep 8, 2025

This change replaces notificationBusInstance references with notificationsBusInstance for consistency with usage in other operators.

This change replaces notificationBusInstance references with
notificationsBusInstance for consistency with usage in other operators.
@openshift-ci openshift-ci bot requested review from abays and dprince September 8, 2025 11:54
@ratailor ratailor requested review from fmount and removed request for dprince and abays September 8, 2025 11:54
Copy link
Contributor

openshift-ci bot commented Sep 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ratailor
Once this PR has been reviewed and has the lgtm label, please assign stuggi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fmount
Copy link
Contributor

fmount commented Sep 8, 2025

Thank you, but -1 for now.
As I mentioned in openstack-k8s-operators/openstack-operator#1591 we need to coordinate this with a particular release to not break what is already shipped.

Copy link
Contributor

openshift-ci bot commented Sep 8, 2025

@ratailor: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/precommit-check c62366f link true /test precommit-check

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@fmount
Copy link
Contributor

fmount commented Sep 8, 2025

Clearly the precommit check indicates that we shouldn't change a parameter that we already released in the same API version, and I think I agree. If we decide to go with this, we should override that check, but I need to check this within the team and circle back to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants