Skip to content

[ansibletest] Add ansibleGitBranch option #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[ansibletest] Add ansibleGitBranch option #340

wants to merge 1 commit into from
+41 −2

Conversation

elfiesmelfie
Copy link

Allow selecting whch branch to run the ansible playbook from

Depends-On: openstack-k8s-operators/tcib#329

@elfiesmelfie elfiesmelfie mentioned this pull request Sep 11, 2025
Draft
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c32891f69dc045f5b48124e4208e6dc8

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 52m 56s
❌ podified-multinode-edpm-deployment-crc-test-operator FAILURE in 2h 42m 41s

@elfiesmelfie
Copy link
Author

recheck

@elfiesmelfie
Copy link
Author

recheck

tokibo tests failed

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d9ba6c3ae99a47c2bb16d31de9220237

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 32m 14s
❌ podified-multinode-edpm-deployment-crc-test-operator FAILURE in 2h 21m 15s

kstrenkova
kstrenkova requested changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@kstrenkova kstrenkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Nice looking patch. Could I ask you to add content you get from running operator-sdk generate kustomize manifests? Also, could you please update the commit message to be a bit more descriptive (why it is getting added, for example)? Thanks.

@elfiesmelfie
[ansibletest] Add ansibleGitBranch option
2601795 
Allow selecting which branch checkout and run the ansible playbook

This allows the playbook to be be run from different branches, which
adds some flexibility:
* The playbook can live on different branches, allowing for versioning
  of the playbook/tests.
* The playbook can be tested in CI prior to merging

Depends-On: openstack-k8s-operators/tcib#329
@elfiesmelfie elfiesmelfie force-pushed the efoley/ansibletest_git_branch branch from 12352a8 to 2601795 Compare September 17, 2025 14:19
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elfiesmelfie
Once this PR has been reviewed and has the lgtm label, please ask for approval from kstrenkova. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kstrenkova
kstrenkova reviewed Sep 18, 2025
View reviewed changes
Copy link
Contributor

@kstrenkova kstrenkova left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the commit message is updated and the related tcib change is merged, I will approve. The change itself seems to be working correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kstrenkova kstrenkova kstrenkova requested changes

@eshulman2 eshulman2 Awaiting requested review from eshulman2

@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday

@olliewalsh olliewalsh Awaiting requested review from olliewalsh

Assignees

@kstrenkova kstrenkova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elfiesmelfie @kstrenkova