CORE-983: Error handling for login page fields

[RoyEJohnson]

CORE-983
CORE-985
When they have errors, email and password fields will have aria-invalid=true and aria-errormessage attributes set
Rolled 985 in here because the changes are closely related and share code.

[github-actions]

❌ Tests failed for Ruby 3.1.

Test Results Report

Summary

• Ruby Version: 3.1
• PostgreSQL Version: 16
• Status: failure

Failures (16)

• 2025-06-10T14:22:59+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2710)] Job ActiveJob::Base (id=1) FAILED (0 prior attempts) with OpenURI::HTTPError:
• 2025-06-10T14:22:59+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2710)] Job ActiveJob::Base (id=2) FAILED (0 prior attempts) with OpenURI::HTTPError: 404 Not Found
• 2025-06-10T14:22:59+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2710)] Job ActiveJob::Base (id=3) FAILED (0 prior attempts) with OpenURI::HTTPError: 504 Gateway Timeout
• 2025-06-10T14:22:59+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2710)] Job ActiveJob::Base (id=4) FAILED (0 prior attempts) with OAuth2::Error:
• 2025-06-10T14:22:59+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2710)] Job ActiveJob::Base (id=5) FAILED (0 prior attempts) with OAuth2::Error:
• 2025-06-10T14:22:59+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2710)] Job ActiveJob::Base (id=6) FAILED (0 prior attempts) with OAuth2::Error:
• 2025-06-10T14:22:59+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2710)] Job ActiveJob::Base (id=7) FAILED (0 prior attempts) with RuntimeError: Some Error
• 2025-06-10T14:22:59+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2710)] Job ActiveJob::Base (id=8) FAILED (0 prior attempts) with ActiveRecord::RecordInvalid: Validation failed:
• 2025-06-10T14:22:59+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2710)] Job ActiveJob::Base (id=9) FAILED (0 prior attempts) with JSON::ParserError: JSON::ParserError
• 2025-06-10T14:22:59+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2710)] Job ActiveJob::Base (id=10) FAILED (0 prior attempts) with NoMethodError: NoMethodError
• 2025-06-10T14:22:59+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2710)] Job ActiveJob::Base (id=11) FAILED (0 prior attempts) with NotYetImplemented: NotYetImplemented
• 2025-06-10T14:22:59+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2710)] Job ActiveJob::Base (id=12) FAILED (0 prior attempts) with ActiveRecord::RecordNotFound: ActiveRecord::RecordNotFound
• 2025-06-10T14:22:59+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2710)] Job ActiveJob::Base (id=13) FAILED (0 prior attempts) with NameError: NameError
• 2025-06-10T14:22:59+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2710)] Job ActiveJob::Base (id=14) FAILED (0 prior attempts) with Addressable::URI::InvalidURIError: Addressable::URI::InvalidURIError
• 2025-06-10T14:22:59+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2710)] Job ActiveJob::Base (id=15) FAILED (0 prior attempts) with NoMethodError: undefined method `message' for nil:NilClass
• 2025-06-10T14:22:59+0000: [Worker(host:pkrvmf6wy0o8zjz pid:2710)] Job ActiveJob::Base (id=16) FAILED (0 prior attempts) with ArgumentError: ArgumentError

Test Log Excerpt

  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[31mROLLBACK�[0m
Redirected to http://127.0.0.1:33483/i/login
Completed 302 Found in 13ms (ActiveRecord: 4.3ms | Allocations: 3639)
Started GET "/i/login" for 127.0.0.1 at 2025-06-10 14:23:52 +0000
Processing by Newflow::LoginController#login_form as HTML
  Rendering layout layouts/newflow_layout.html.erb
  Rendering newflow/login/login_form.html.erb within layouts/newflow_layout
  Rendered newflow/_tab_group.html.erb (Duration: 0.5ms | Allocations: 168)
  Rendered newflow/_form_divider.html.erb (Duration: 0.0ms | Allocations: 6)
  Rendered newflow/login/login_form.html.erb within layouts/newflow_layout (Duration: 2.7ms | Allocations: 1332)
  Rendered layouts/_google_tag_manager.html.erb (Duration: 0.0ms | Allocations: 5)
  Rendered layouts/_tag_manager_snippet.html.erb (Duration: 0.1ms | Allocations: 5)
  �[1m�[36mBanner Load (0.5ms)�[0m  �[1m�[34mSELECT "banners".* FROM "banners" WHERE (expires_at > '2025-06-10 14:23:52.110787')�[0m
  Rendered layouts/_main_menu.html.erb (Duration: 0.9ms | Allocations: 581)
  Rendered layouts/_newflow_footer.html.erb (Duration: 0.8ms | Allocations: 693)
  �[1m�[36mSettings::Db::Store Load (0.4ms)�[0m  �[1m�[34mSELECT var, value FROM "settings"�[0m
  Rendered layouts/_chat.html.erb (Duration: 1.5ms | Allocations: 237)
  Rendered layout layouts/newflow_layout.html.erb (Duration: 18.1ms | Allocations: 15483)
Completed 200 OK in 20ms (Views: 17.7ms | ActiveRecord: 0.9ms | Allocations: 16021)
  �[1m�[36mTRANSACTION (0.3ms)�[0m  �[1m�[35mBEGIN�[0m
  �[1m�[35m (1.2ms)�[0m  �[1m�[35mALTER TABLE "schools" DISABLE TRIGGER ALL;ALTER TABLE "blazer_dashboard_queries" DISABLE TRIGGER ALL;ALTER TABLE "security_logs" DISABLE TRIGGER ALL;ALTER TABLE "schema_migrations" DISABLE TRIGGER ALL;ALTER TABLE "ar_internal_metadata" DISABLE TRIGGER ALL;ALTER TABLE "delayed_jobs" DISABLE TRIGGER ALL;ALTER TABLE "delayed_workers" DISABLE TRIGGER ALL;ALTER TABLE "email_domains" DISABLE TRIGGER ALL;ALTER TABLE "external_ids" DISABLE TRIGGER ALL;ALTER TABLE "fine_print_signatures" DISABLE TRIGGER ALL;ALTER TABLE "group_members" DISABLE TRIGGER ALL;ALTER TABLE "group_nestings" DISABLE TRIGGER ALL;ALTER TABLE "group_owners" DISABLE TRIGGER ALL;ALTER TABLE "groups" DISABLE TRIGGER ALL;ALTER TABLE "application_groups" DISABLE TRIGGER ALL;ALTER TABLE "application_users" DISABLE TRIGGER ALL;ALTER TABLE "identities" DISABLE TRIGGER ALL;ALTER TABLE "pre_auth_states" DISABLE TRIGGER ALL;ALTER TABLE "sequential_failures" DISABLE TRIGGER ALL;ALTER TABLE "settings" DISABLE TRIGGER ALL;ALTER TABLE "sheerid_verifications" DISABLE TRIGGER ALL;ALTER TABLE "user_external_uuids" DISABLE TRIGGER ALL;ALTER TABLE "users" DISABLE TRIGGER ALL;ALTER TABLE "oauth_applications" DISABLE TRIGGER ALL;ALTER TABLE "oauth_access_grants" DISABLE TRIGGER ALL;ALTER TABLE "authentications" DISABLE TRIGGER ALL;ALTER TABLE "banners" DISABLE TRIGGER ALL;ALTER TABLE "blazer_audits" DISABLE TRIGGER ALL;ALTER TABLE "blazer_dashboards" DISABLE TRIGGER ALL;ALTER TABLE "blazer_queries" DISABLE TRIGGER ALL;ALTER TABLE "contact_infos" DISABLE TRIGGER ALL;ALTER TABLE "fine_print_contracts" DISABLE TRIGGER ALL;ALTER TABLE "messages" DISABLE TRIGGER ALL;ALTER TABLE "blazer_checks" DISABLE TRIGGER ALL;ALTER TABLE "message_bodies" DISABLE TRIGGER ALL;ALTER TABLE "message_recipients" DISABLE TRIGGER ALL;ALTER TABLE "oauth_access_tokens" DISABLE TRIGGER ALL�[0m
  �[1m�[36mTRANSACTION (0.4ms)�[0m  �[1m�[35mCOMMIT�[0m
  �[1m�[35m (98.6ms)�[0m  �[1m�[35mTRUNCATE TABLE "schools", "blazer_dashboard_queries", "security_logs", "delayed_jobs", "delayed_workers", "email_domains", "external_ids", "fine_print_signatures", "group_members", "group_nestings", "group_owners", "groups", "application_groups", "application_users", "identities", "pre_auth_states", "sequential_failures", "settings", "sheerid_verifications", "user_external_uuids", "users", "oauth_applications", "oauth_access_grants", "authentications", "banners", "blazer_audits", "blazer_dashboards", "blazer_queries", "contact_infos", "fine_print_contracts", "messages", "blazer_checks", "message_bodies", "message_recipients", "oauth_access_tokens" RESTART IDENTITY RESTRICT;�[0m
  �[1m�[36mTRANSACTION (0.8ms)�[0m  �[1m�[35mBEGIN�[0m
  �[1m�[35m (1.2ms)�[0m  �[1m�[35mALTER TABLE "schools" ENABLE TRIGGER ALL;ALTER TABLE "blazer_dashboard_queries" ENABLE TRIGGER ALL;ALTER TABLE "security_logs" ENABLE TRIGGER ALL;ALTER TABLE "schema_migrations" ENABLE TRIGGER ALL;ALTER TABLE "ar_internal_metadata" ENABLE TRIGGER ALL;ALTER TABLE "delayed_jobs" ENABLE TRIGGER ALL;ALTER TABLE "delayed_workers" ENABLE TRIGGER ALL;ALTER TABLE "email_domains" ENABLE TRIGGER ALL;ALTER TABLE "external_ids" ENABLE TRIGGER ALL;ALTER TABLE "fine_print_signatures" ENABLE TRIGGER ALL;ALTER TABLE "group_members" ENABLE TRIGGER ALL;ALTER TABLE "group_nestings" ENABLE TRIGGER ALL;ALTER TABLE "group_owners" ENABLE TRIGGER ALL;ALTER TABLE "groups" ENABLE TRIGGER ALL;ALTER TABLE "application_groups" ENABLE TRIGGER ALL;ALTER TABLE "application_users" ENABLE TRIGGER ALL;ALTER TABLE "identities" ENABLE TRIGGER ALL;ALTER TABLE "pre_auth_states" ENABLE TRIGGER ALL;ALTER TABLE "sequential_failures" ENABLE TRIGGER ALL;ALTER TABLE "settings" ENABLE TRIGGER ALL;ALTER TABLE "sheerid_verifications" ENABLE TRIGGER ALL;ALTER TABLE "user_external_uuids" ENABLE TRIGGER ALL;ALTER TABLE "users" ENABLE TRIGGER ALL;ALTER TABLE "oauth_applications" ENABLE TRIGGER ALL;ALTER TABLE "oauth_access_grants" ENABLE TRIGGER ALL;ALTER TABLE "authentications" ENABLE TRIGGER ALL;ALTER TABLE "banners" ENABLE TRIGGER ALL;ALTER TABLE "blazer_audits" ENABLE TRIGGER ALL;ALTER TABLE "blazer_dashboards" ENABLE TRIGGER ALL;ALTER TABLE "blazer_queries" ENABLE TRIGGER ALL;ALTER TABLE "contact_infos" ENABLE TRIGGER ALL;ALTER TABLE "fine_print_contracts" ENABLE TRIGGER ALL;ALTER TABLE "messages" ENABLE TRIGGER ALL;ALTER TABLE "blazer_checks" ENABLE TRIGGER ALL;ALTER TABLE "message_bodies" ENABLE TRIGGER ALL;ALTER TABLE "message_recipients" ENABLE TRIGGER ALL;ALTER TABLE "oauth_access_tokens" ENABLE TRIGGER ALL�[0m
  �[1m�[36mTRANSACTION (0.3ms)�[0m  �[1m�[35mCOMMIT�[0m
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[35mBEGIN�[0m
  �[1m�[36mFinePrint::Contract Exists? (0.4ms)�[0m  �[1m�[34mSELECT 1 AS one FROM "fine_print_contracts" WHERE "fine_print_contracts"."version" = $1 AND "fine_print_contracts"."name" = $2 LIMIT $3�[0m  [["version", 1], ["name", "general_terms_of_use"], ["LIMIT", 1]]
  �[1m�[36mFinePrint::Contract Create (0.4ms)�[0m  �[1m�[32mINSERT INTO "fine_print_contracts" ("name", "version", "title", "content", "created_at", "updated_at") VALUES ($1, $2, $3, $4, $5, $6) RETURNING "id"�[0m  [["name", "general_terms_of_use"], ["version", 1], ["title", "Terms of Use"], ["content", "Placeholder for general terms of use, required for new installations to function"], ["created_at", "2025-06-10 14:23:52.403727"], ["updated_at", "2025-06-10 14:23:52.403727"]]
  �[1m�[36mTRANSACTION (0.4ms)�[0m  �[1m�[35mCOMMIT�[0m
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[35mBEGIN�[0m
  �[1m�[36mFinePrint::Contract Exists? (0.3ms)�[0m  �[1m�[34mSELECT 1 AS one FROM "fine_print_contracts" WHERE "fine_print_contracts"."version" = $1 AND "fine_print_contracts"."name" = $2 LIMIT $3�[0m  [["version", 1], ["name", "privacy_policy"], ["LIMIT", 1]]
  �[1m�[36mFinePrint::Contract Create (0.3ms)�[0m  �[1m�[32mINSERT INTO "fine_print_contracts" ("name", "version", "title", "content", "created_at", "updated_at") VALUES ($1, $2, $3, $4, $5, $6) RETURNING "id"�[0m  [["name", "privacy_policy"], ["version", 1], ["title", "Privacy Policy"], ["content", "Placeholder for privacy policy, required for new installations to function"], ["created_at", "2025-06-10 14:23:52.407453"], ["updated_at", "2025-06-10 14:23:52.407453"]]
  �[1m�[36mTRANSACTION (0.3ms)�[0m  �[1m�[35mCOMMIT�[0m
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[35mBEGIN�[0m
  �[1m�[35m (0.7ms)�[0m  �[1m�[35mALTER TABLE "schools" DISABLE TRIGGER ALL;ALTER TABLE "blazer_dashboard_queries" DISABLE TRIGGER ALL;ALTER TABLE "security_logs" DISABLE TRIGGER ALL;ALTER TABLE "schema_migrations" DISABLE TRIGGER ALL;ALTER TABLE "ar_internal_metadata" DISABLE TRIGGER ALL;ALTER TABLE "delayed_jobs" DISABLE TRIGGER ALL;ALTER TABLE "delayed_workers" DISABLE TRIGGER ALL;ALTER TABLE "email_domains" DISABLE TRIGGER ALL;ALTER TABLE "external_ids" DISABLE TRIGGER ALL;ALTER TABLE "fine_print_signatures" DISABLE TRIGGER ALL;ALTER TABLE "group_members" DISABLE TRIGGER ALL;ALTER TABLE "group_nestings" DISABLE TRIGGER ALL;ALTER TABLE "group_owners" DISABLE TRIGGER ALL;ALTER TABLE "groups" DISABLE TRIGGER ALL;ALTER TABLE "application_groups" DISABLE TRIGGER ALL;ALTER TABLE "application_users" DISABLE TRIGGER ALL;ALTER TABLE "identities" DISABLE TRIGGER ALL;ALTER TABLE "pre_auth_states" DISABLE TRIGGER ALL;ALTER TABLE "sequential_failures" DISABLE TRIGGER ALL;ALTER TABLE "settings" DISABLE TRIGGER ALL;ALTER TABLE "sheerid_verifications" DISABLE TRIGGER ALL;ALTER TABLE "user_external_uuids" DISABLE TRIGGER ALL;ALTER TABLE "users" DISABLE TRIGGER ALL;ALTER TABLE "oauth_applications" DISABLE TRIGGER ALL;ALTER TABLE "oauth_access_grants" DISABLE TRIGGER ALL;ALTER TABLE "authentications" DISABLE TRIGGER ALL;ALTER TABLE "banners" DISABLE TRIGGER ALL;ALTER TABLE "blazer_audits" DISABLE TRIGGER ALL;ALTER TABLE "blazer_dashboards" DISABLE TRIGGER ALL;ALTER TABLE "blazer_queries" DISABLE TRIGGER ALL;ALTER TABLE "contact_infos" DISABLE TRIGGER ALL;ALTER TABLE "fine_print_contracts" DISABLE TRIGGER ALL;ALTER TABLE "messages" DISABLE TRIGGER ALL;ALTER TABLE "blazer_checks" DISABLE TRIGGER ALL;ALTER TABLE "message_bodies" DISABLE TRIGGER ALL;ALTER TABLE "message_recipients" DISABLE TRIGGER ALL;ALTER TABLE "oauth_access_tokens" DISABLE TRIGGER ALL�[0m
  �[1m�[36mTRANSACTION (0.3ms)�[0m  �[1m�[35mCOMMIT�[0m
  �[1m�[35m (101.1ms)�[0m  �[1m�[35mTRUNCATE TABLE "schools", "blazer_dashboard_queries", "security_logs", "delayed_jobs", "delayed_workers", "email_domains", "external_ids", "fine_print_signatures", "group_members", "group_nestings", "group_owners", "groups", "application_groups", "application_users", "identities", "pre_auth_states", "sequential_failures", "settings", "sheerid_verifications", "user_external_uuids", "users", "oauth_applications", "oauth_access_grants", "authentications", "banners", "blazer_audits", "blazer_dashboards", "blazer_queries", "contact_infos", "fine_print_contracts", "messages", "blazer_checks", "message_bodies", "message_recipients", "oauth_access_tokens" RESTART IDENTITY RESTRICT;�[0m
  �[1m�[36mTRANSACTION (0.6ms)�[0m  �[1m�[35mBEGIN�[0m
  �[1m�[35m (1.2ms)�[0m  �[1m�[35mALTER TABLE "schools" ENABLE TRIGGER ALL;ALTER TABLE "blazer_dashboard_queries" ENABLE TRIGGER ALL;ALTER TABLE "security_logs" ENABLE TRIGGER ALL;ALTER TABLE "schema_migrations" ENABLE TRIGGER ALL;ALTER TABLE "ar_internal_metadata" ENABLE TRIGGER ALL;ALTER TABLE "delayed_jobs" ENABLE TRIGGER ALL;ALTER TABLE "delayed_workers" ENABLE TRIGGER ALL;ALTER TABLE "email_domains" ENABLE TRIGGER ALL;ALTER TABLE "external_ids" ENABLE TRIGGER ALL;ALTER TABLE "fine_print_signatures" ENABLE TRIGGER ALL;ALTER TABLE "group_members" ENABLE TRIGGER ALL;ALTER TABLE "group_nestings" ENABLE TRIGGER ALL;ALTER TABLE "group_owners" ENABLE TRIGGER ALL;ALTER TABLE "groups" ENABLE TRIGGER ALL;ALTER TABLE "application_groups" ENABLE TRIGGER ALL;ALTER TABLE "application_users" ENABLE TRIGGER ALL;ALTER TABLE "identities" ENABLE TRIGGER ALL;ALTER TABLE "pre_auth_states" ENABLE TRIGGER ALL;ALTER TABLE "sequential_failures" ENABLE TRIGGER ALL;ALTER TABLE "settings" ENABLE TRIGGER ALL;ALTER TABLE "sheerid_verifications" ENABLE TRIGGER ALL;ALTER TABLE "user_external_uuids" ENABLE TRIGGER ALL;ALTER TABLE "users" ENABLE TRIGGER ALL;ALTER TABLE "oauth_applications" ENABLE TRIGGER ALL;ALTER TABLE "oauth_access_grants" ENABLE TRIGGER ALL;ALTER TABLE "authentications" ENABLE TRIGGER ALL;ALTER TABLE "banners" ENABLE TRIGGER ALL;ALTER TABLE "blazer_audits" ENABLE TRIGGER ALL;ALTER TABLE "blazer_dashboards" ENABLE TRIGGER ALL;ALTER TABLE "blazer_queries" ENABLE TRIGGER ALL;ALTER TABLE "contact_infos" ENABLE TRIGGER ALL;ALTER TABLE "fine_print_contracts" ENABLE TRIGGER ALL;ALTER TABLE "messages" ENABLE TRIGGER ALL;ALTER TABLE "blazer_checks" ENABLE TRIGGER ALL;ALTER TABLE "message_bodies" ENABLE TRIGGER ALL;ALTER TABLE "message_recipients" ENABLE TRIGGER ALL;ALTER TABLE "oauth_access_tokens" ENABLE TRIGGER ALL�[0m
  �[1m�[36mTRANSACTION (0.4ms)�[0m  �[1m�[35mCOMMIT�[0m
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[35mBEGIN�[0m
  �[1m�[36mFinePrint::Contract Exists? (0.4ms)�[0m  �[1m�[34mSELECT 1 AS one FROM "fine_print_contracts" WHERE "fine_print_contracts"."version" = $1 AND "fine_print_contracts"."name" = $2 LIMIT $3�[0m  [["version", 1], ["name", "general_terms_of_use"], ["LIMIT", 1]]
  �[1m�[36mFinePrint::Contract Create (0.4ms)�[0m  �[1m�[32mINSERT INTO "fine_print_contracts" ("name", "version", "title", "content", "created_at", "updated_at") VALUES ($1, $2, $3, $4, $5, $6) RETURNING "id"�[0m  [["name", "general_terms_of_use"], ["version", 1], ["title", "Terms of Use"], ["content", "Placeholder for general terms of use, required for new installations to function"], ["created_at", "2025-06-10 14:23:52.521489"], ["updated_at", "2025-06-10 14:23:52.521489"]]
  �[1m�[36mTRANSACTION (0.3ms)�[0m  �[1m�[35mCOMMIT�[0m
  �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[35mBEGIN�[0m
  �[1m�[36mFinePrint::Contract Exists? (0.2ms)�[0m  �[1m�[34mSELECT 1 AS one FROM "fine_print_contracts" WHERE "fine_print_contracts"."version" = $1 AND "fine_print_contracts"."name" = $2 LIMIT $3�[0m  [["version", 1], ["name", "privacy_policy"], ["LIMIT", 1]]
  �[1m�[36mFinePrint::Contract Create (0.3ms)�[0m  �[1m�[32mINSERT INTO "fine_print_contracts" ("name", "version", "title", "content", "created_at", "updated_at") VALUES ($1, $2, $3, $4, $5, $6) RETURNING "id"�[0m  [["name", "privacy_policy"], ["version", 1], ["title", "Privacy Policy"], ["content", "Placeholder for privacy policy, required for new installations to function"], ["created_at", "2025-06-10 14:23:52.524838"], ["updated_at", "2025-06-10 14:23:52.524838"]]
  �[1m�[36mTRANSACTION (0.3ms)�[0m  �[1m�[35mCOMMIT�[0m

Check the workflow run for more details.