Skip to content

Bump tar and npm in /playwright #2344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 17, 2024

https://openstax.atlassian.net/browse/DISCO-315

Removes tar. It's no longer used after updating ancestor dependency npm. These dependencies need to be updated together.

Removes tar

Updates npm from 9.8.0 to 10.8.3

Release notes

Sourced from npm's releases.

libnpmhook: v10.0.5

10.0.5 (2024-05-15)

Dependencies

Chores

libnpmhook: v10.0.4

10.0.4 (2024-04-30)

Bug Fixes

Dependencies

libnpmhook: v10.0.3

10.0.3 (2024-04-25)

Dependencies

libnpmhook: v10.0.2

10.0.2 (2024-04-03)

Dependencies

Changelog

Sourced from npm's changelog.

10.8.3 (2024-08-28)

Bug Fixes

Documentation

Dependencies

Chores

10.8.2 (2024-07-09)

Bug Fixes

Documentation

Dependencies

... (truncated)

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot requested a review from a team as a code owner September 17, 2024 13:08
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 17, 2024
@dependabot dependabot bot requested a review from gregfitch September 17, 2024 13:08
@dependabot dependabot bot added the javascript Pull requests that update Javascript code label Sep 17, 2024
@TomWoodward TomWoodward temporarily deployed to rex-web-dependabot-npm--suv8j5 September 17, 2024 13:08 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-dependabot-npm--suv8j5 September 17, 2024 13:34 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-dependabot-npm--suv8j5 September 17, 2024 13:34 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-dependabot-npm--suv8j5 September 17, 2024 13:35 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-dependabot-npm--suv8j5 September 17, 2024 13:35 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-dependabot-npm--suv8j5 September 17, 2024 13:36 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-dependabot-npm--suv8j5 September 17, 2024 13:36 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-dependabot-npm--suv8j5 September 17, 2024 15:00 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-dependabot-npm--suv8j5 September 17, 2024 15:25 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-dependabot-npm--suv8j5 September 17, 2024 21:38 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-dependabot-npm--suv8j5 September 17, 2024 22:02 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-dependabot-npm--suv8j5 September 19, 2024 15:55 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-dependabot-npm--suv8j5 September 23, 2024 18:48 Inactive
@Dantemss Dantemss changed the title Bump tar and npm in /playwright CORE-784 Bump tar and npm in /playwright Feb 21, 2025
@Dantemss Dantemss changed the title CORE-784 Bump tar and npm in /playwright Bump tar and npm in /playwright Feb 21, 2025
Copy link
Member

@Dantemss Dantemss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to break the playwright scripts

@staxly staxly bot requested a review from a team as a code owner April 15, 2025 17:32
@staxly staxly bot requested a review from Dantemss April 15, 2025 17:32
@Dantemss
Copy link
Member

@omehes this is a playwright dependency PR so you should check if it's still relevant (do you even still need the package files?) and if merging doesn't break anything

Copy link
Contributor

@omehes omehes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand, it looks OK. Bumping version numbers up...

@Dantemss
Copy link
Member

It used to break the existing playwright TS tests, but since you removed those I guess it's fine now

@Dantemss
Copy link
Member

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 30, 2025

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@Dantemss
Copy link
Member

@dependabot recreate

Removes [tar](https://github.com/isaacs/node-tar). It's no longer used after updating ancestor dependency [npm](https://github.com/npm/cli). These dependencies need to be updated together.


Removes `tar`

Updates `npm` from 9.8.0 to 10.8.3
- [Release notes](https://github.com/npm/cli/releases)
- [Changelog](https://github.com/npm/cli/blob/latest/CHANGELOG.md)
- [Commits](npm/cli@v9.8.0...v10.8.3)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
- dependency-name: npm
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/playwright/multi-893bcbaee7 branch from 082f848 to 953c70e Compare April 30, 2025 15:10
@Dantemss Dantemss merged commit 1058fcd into main Apr 30, 2025
6 of 8 checks passed
@Dantemss Dantemss deleted the dependabot/npm_and_yarn/playwright/multi-893bcbaee7 branch April 30, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants