fixed the disable and enable button position

[draunger]

Description

Approach

I have used position absolute property and margin property to set buttons.

Before the fix

After the fix

Attached issue

Closes #8878

[draunger]

@bhousel can you review my PR and if you seems it has some issue please tell me regarding this

[bhousel]

@bhousel can you review my PR and if you seems it has some issue please tell me regarding this

Using absolute positioning and a -532px margin is certainly one way to move the text, but it's not how I would do it.
What if later someone wants to change the checkboxes or the font or something.

[draunger]

@bhousel ok i understand then please give me some time i can change my approach
but sir one question , without applying css how we can change the position of the buttons

[bhousel]

@bhousel ok i understand then please give me some time i can change my approach
but sir one question , without applying css how we can change the position of the buttons

insert them into the document where you want them to be

[draunger]

hey @bhousel i have changed the position of the footer without css but now it look like this but in this image map feature text and both button i.e(disable all and enable all) are not aligning in the same line.

if i use absolute property in map feature text css then it looks like this :
means i have apply css on the text map feature not on the buttons :
so which i use above or this ??

[draunger]

hey @bhousel what do you think which method i use as stated above ?

[k-yle]

Hi @draunger, as Bryan mentioned, using a margin of -532px isn't a particularly robust solution. It also has consqeuences for other components that use the same class name.

It would be more idiomatic to move div.feature-list-links above ul.layer-feature-list. You can find the relevant code here:

iD/modules/ui/sections/map_features.js

Lines 27 to 29 in ff8f044

	var footer = containerEnter
	.append('div')
	.attr('class', 'feature-list-links section-footer');

[draunger]

@k-yle ok sending its commit using moving div.feature-list-links above ul.layer-feature-list