Skip to content

Conversation

@mmd-osm
Copy link
Contributor

@mmd-osm mmd-osm commented Jan 27, 2025

Follow up for:

Even better would be to refactor the XML parser along the same lines as the JSON parser after fixing the XML tests and before adding the JSON parser but that's obviously not essential so I wouldn't insist on that.

Here's an attempt to make the XML parser resemble the JSON implementation. All the getElementsByTagName and getAttribute tend to make the code more difficult to read, compared to the JSON version. YMMV.

@tomhughes
Copy link
Member

Given the issues using map that @AntonKhorev identified I think this is probably good to merge as is, thanks.

@tomhughes tomhughes merged commit fd59454 into openstreetmap:master Jan 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants