Add functionality to cancel data loading #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses "Map Data checkbox: perhaps use toggle slider instead" issue mentioned in the openstreetmap/openstreetmap-website#4931 and openstreetmap/openstreetmap-website#5009 (comment). It is continuation of #38.
Currently
asynchronously loading datahas no functionality to be canceled. Therefore, if user starts loading big amount of data and in the middle of the process decides to cancel it (even ifremoving each layerwas called), it will load all elements asynchronously (and only after that will begin to remove all the elements).This PR adds functionality to cancel asynchronous loading/removing in the middle of the process.
Was manually tested in the openstreetmap/openstreetmap-website#5009
Connected to the PR openstreetmap/openstreetmap-website#5009