Use webp format for tracestrack topo #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Checking https://caniuse.com/webp the main question mark is MacOS/iOS which have only supported webp since 2020 but that's probably good enough. |
Member
|
Can you rebase this please so that the tests can run? |
Contributor
Author
|
Just synced! |
Contributor
Author
|
Hi @tomhughes do you know why some users still use png url even today? Is the change fully propagated to CDN? I see logs like the following: |
Member
|
Well I'm sure people will be using old versions of this code for many years to come, or just copy and pasting the URL to other systems, and some of them may be devious enough to fake the referer as well. |
Contributor
Author
|
I see. In that case I'll be allowing png access for this key longer and monitoring the png usage separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracestrack Maps recently started providing webp tiles. webp is widely supported and has better compression. It loads faster without noticeable quality degradation. This is the preferred way to serve tiles.
openstreetmap/openstreetmap-website#5996