Add topSongsByArtistId extension#259
Merged
Merged
Conversation
✅ Deploy Preview for opensubsonic ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
For the record this also fit #258 ;) filter artistId sort by topSongs and is one more argument for it ;) |
paulijar
approved these changes
Jul 21, 2026
kgarner7
approved these changes
Jul 22, 2026
sentriz
force-pushed
the
feat/gettopsongs-artist-id
branch
from
July 24, 2026 11:38
a5d98ad to
60c21aa
Compare
paulijar
approved these changes
Jul 24, 2026
deluan
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getTopSongscurrently only accepts an artist name. Which is ambiguous since twoartists can share the same name, so the server has to guess which one the client
meant
Passing an artist ID removes the ambiguity
exact artist directly, disambiguating same named artists
artist from the ID it already knows, then fetch/filter that artist's top songs
precisely instead of round-tripping a name