-
Notifications
You must be signed in to change notification settings - Fork 1
feat(staging): 25.12 genetics staging data update #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
project-defiant
wants to merge
20
commits into
dev
Choose a base branch
from
25-09-harmonisation
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project-defiant
commented
Nov 14, 2025
src/orchestration/dags/config/gwas_catalog_sumstats_susie_finemapping.yaml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR adds the configuration changes to the gentropy staging dags used to generate 25.12 release data.
It also unifies the way to build orchestration images. The updated logic is in the
artifact.yamlfile that corresponds to the github action responsible for building and pushing the orchestration related Docker images.Implementations
The PR includes:
artifact.yamlis triggered - now only manually.artifact.yamlis triggered from the branch, no image is build, if it is triggered from tag, then images are build and pushed to the registry - this ensures no overwrites (branch name is not used as image tag).open-targets-genetics-devproject via OIDC, not using long lifetime service account anymore.The most important change is that now we build both images:
and include them into the GitHub Container Registry for public usage.
Action was tested on
v25.12-staging.5which produced artifacts for the repository and GAR.