fix: Sonarcloud, tests, documentation #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify test methods and assertions in ConvertToZTDFTest to use package-private visibility and improve assertion clarity. Enhance Javadocs for ConvertToZTDF, AbstractTDFProcessor, and related classes, including property descriptors and methods to improve code readability and maintainability.
# Conflicts: # pom.xml
Eliminated the maven-surefire-plugin configuration from pom.xml. Added jacoco-maven-plugin to handle code coverage and reporting, ensuring it generates reports in XML format after test phase. Integrated plugin management for consistent usage across project modules.
The report-aggregate execution in the POM file is unnecessary and has been removed. This prevents the redundant verification phase execution, streamlining the build process. The remaining configuration continues to support the report execution during the test phase.
Eliminated the JaCoCo plugin configuration from the POM file. This change removes automated code coverage reporting steps and associated configurations.
Eliminated redundant equals and hashCode methods from AbstractTDFProcessor, ConvertToZTDF, and SimpleOpenTDFControllerService classes. Refactored some code in ConvertToZTDF for better readability and maintainability.
Refactor to address InterruptedException in an outer try-catch for better error handling. This change ensures that the thread's interrupted status is properly restored in both inner and outer catch blocks.
Inserted a blank line after <modelVersion>4.0.0</modelVersion> to improve code readability. This change does not affect the functionality but enhances the visual structure of the XML file.
Implemented caching for Maven and SonarCloud packages in GitHub workflows to speed up CI builds. Added a `develop` profile with the Maven Surefire Plugin in `pom.xml` for better test isolation and coverage during development.
|
ttschampel
approved these changes
Oct 18, 2024
pflynn-virtru
pushed a commit
that referenced
this pull request
Oct 18, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>0.5.0</summary> ## [0.5.0](v0.4.0...v0.5.0) (2024-10-18) ### Bug Fixes * Sonarcloud, tests, documentation ([#29](#29)) ([87d58ec](87d58ec)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify test methods and assertions in ConvertToZTDFTest to use package-private visibility and improve assertion clarity. Enhance Javadocs for ConvertToZTDF, AbstractTDFProcessor, and related classes, including property descriptors and methods to improve code readability and maintainability.
DSP-154