🔥 Remove explicit content-length (#255)

This is unused and inaccurate
opentdf · Nov 15, 2023 · 3224391 · 3224391
1 parent 6e5aaca
commit 3224391
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 47 deletions.
diff --git a/lib/tdf3/src/client/DecoratedReadableStream.ts b/lib/tdf3/src/client/DecoratedReadableStream.ts
@@ -27,7 +27,6 @@ export class DecoratedReadableStream {
   on: EventEmitter['on'];
   emit: EventEmitter['emit'];
   metadata?: Metadata;
-  contentLength?: number;
   manifest: Manifest;
   upsertResponse?: UpsertResponse;
   fileStreamServiceWorker?: string;
@@ -110,7 +109,6 @@ export class DecoratedReadableStream {
     }
 
     const fileStream = streamSaver.createWriteStream(filepath, {
-      ...(this.contentLength && { size: this.contentLength }),
       writableStrategy: { highWaterMark: 1 },
       readableStrategy: { highWaterMark: 1 },
     });

diff --git a/lib/tdf3/src/client/builders.ts b/lib/tdf3/src/client/builders.ts
@@ -32,7 +32,6 @@ export type EncryptParams = {
   scope?: Scope;
   metadata?: Metadata;
   keypair?: CryptoKeyPair;
-  contentLength?: number;
   offline?: boolean;
   windowSize?: number;
   asHtml?: boolean;
@@ -74,15 +73,6 @@ class EncryptParamsBuilder {
     this._params = { ...params };
   }
 
-  setContentLength(contentLength: number) {
-    this._params.contentLength = contentLength;
-  }
-
-  withContentLength(contentLength: number) {
-    this.setContentLength(contentLength);
-    return this;
-  }
-
   getStreamSource(): EncryptParams['source'] | undefined {
     return this._params.source;
   }
@@ -485,12 +475,11 @@ export type DecryptSource =
   | { type: 'file-browser'; location: Blob };
 
 export type DecryptParams = {
-  source: DecryptSource;
-  opts?: { keypair: PemKeyPair };
   eo?: EntityObject;
+  source: DecryptSource;
   keyMiddleware?: DecryptKeyMiddleware;
   streamMiddleware?: DecryptStreamMiddleware;
-} & Pick<EncryptParams, 'contentLength' | 'keypair'>;
+};
 
 /**
  * A builder capable of constructing the necessary parameters object for a
@@ -518,15 +507,6 @@ class DecryptParamsBuilder {
     };
   }
 
-  setContentLength(contentLength: number) {
-    this._params.contentLength = contentLength;
-  }
-
-  withContentLength(contentLength: number) {
-    this.setContentLength(contentLength);
-    return this;
-  }
-
   getStreamSource(): DecryptSource | undefined {
     return this._params.source;
   }

diff --git a/remote-store/package-lock.json b/remote-store/package-lock.json
diff --git a/remote-store/src/index.ts b/remote-store/src/index.ts
@@ -1,7 +1,6 @@
 import {
   S3Client,
   GetObjectCommand,
-  HeadObjectCommand,
   S3ClientConfig,
   AbortMultipartUploadCommandOutput,
   CompleteMultipartUploadCommandOutput,
@@ -93,19 +92,6 @@ export const setRemoteStoreAsStream = async (
 
   const s3 = new S3Client(storageParams);
 
-  const s3Metadata = await s3.send(
-    new HeadObjectCommand({
-      Key: FILE_NAME,
-      Bucket: BUCKET_NAME,
-    })
-  );
-
-  if (typeof s3Metadata.ContentLength === 'number') {
-    if ((builder as DecryptParamsBuilder).setContentLength) {
-      (builder as DecryptParamsBuilder).setContentLength(s3Metadata.ContentLength);
-    }
-  }
-
   const s3download = await s3.send(
     new GetObjectCommand({
       Key: FILE_NAME,

diff --git a/web-app/package-lock.json b/web-app/package-lock.json