Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Unifies DPoP and client signing keys #267

Merged
merged 7 commits into from
May 2, 2024

Conversation

dmihalcik-virtru
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru commented Apr 29, 2024

  • Currently, the js client generates two different RSA keypairs for signing the DPoP proofs and the 'signed request token' - the body of the rewrap request. This removes the duplication and instead uses the same keypair to sign both the DPoP proofs and the rewrap request. This is required by the new go KAS implementation, which uses the DPoP key when present to validate the rewrap body

@dmihalcik-virtru dmihalcik-virtru requested a review from a team as a code owner April 29, 2024 15:19
Copy link

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

@dmihalcik-virtru dmihalcik-virtru force-pushed the feature/one-signing-keypair branch from 0aef8da to 9b2dc1b Compare April 29, 2024 15:27
pflynn-virtru
pflynn-virtru previously approved these changes Apr 30, 2024
Copy link

sonarqubecloud bot commented May 1, 2024

@dmihalcik-virtru dmihalcik-virtru merged commit 13936cf into main May 2, 2024
9 checks passed
@dmihalcik-virtru dmihalcik-virtru deleted the feature/one-signing-keypair branch May 2, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants