chore: Removes ajv validation of attribute set #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dmihalcik-virtru
commented
May 3, 2024
dmihalcik-virtru
commented
- We aren't doing attribute validation elsewhere
- This is less necessary after the switch to typescript
- the library is heavy and doesn't play well with our esm based tooling
dmihalcik-virtru
force-pushed
the
feature/remove-ajv
branch
from
719767e to
ac05737
Compare
- We aren't doing attribute validation elsewhere - This is less necessary after the switch to typescript - the library is heavy and doesn't play well with our esm based tooling
dmihalcik-virtru
force-pushed
the
feature/remove-ajv
branch
from
ac05737 to
0c35877
Compare
|
pflynn-virtru
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.