Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lets nanoTDF client take options instead #278

Merged
merged 3 commits into from
May 10, 2024

Conversation

dmihalcik-virtru
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru commented May 9, 2024

  • Changes nanotdf constructor parameter to be an options object instead of ordered parameters
  • Lets web-app backend be configurable
  • fix some tsc issues in web-app
  • Some fixes for dpop/signing key generation flows

@dmihalcik-virtru dmihalcik-virtru requested a review from a team as a code owner May 9, 2024 02:22
Copy link

github-actions bot commented May 9, 2024

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

@dmihalcik-virtru dmihalcik-virtru force-pushed the feature/fix-ts-web-app branch from 5d1853e to 8fc299b Compare May 9, 2024 13:43
Copy link

github-actions bot commented May 9, 2024

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

dmihalcik-virtru and others added 3 commits May 10, 2024 10:54
- Adds `tsc` build of web-app to makefile
- fixes existing typescript issues in web app, and some cleanup
@dmihalcik-virtru dmihalcik-virtru force-pushed the feature/fix-ts-web-app branch from d6e8ca5 to d00fdf6 Compare May 10, 2024 15:13
@dmihalcik-virtru dmihalcik-virtru changed the title feat!: lets nanoTDF client take options instead feat: lets nanoTDF client take options instead May 10, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
35.8% Coverage on New Code (required ≥ 80%)
4.1% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@dmihalcik-virtru dmihalcik-virtru requested a review from ryanulit May 10, 2024 17:11
@dmihalcik-virtru dmihalcik-virtru merged commit 048bd30 into main May 10, 2024
8 of 9 checks passed
@dmihalcik-virtru dmihalcik-virtru deleted the feature/fix-ts-web-app branch May 10, 2024 19:39
dmihalcik-virtru added a commit that referenced this pull request May 13, 2024
- Changes nanotdf constructor parameter to be an options object instead of ordered parameters
- Lets web-app backend be configurable
- Some fixes for dpop/signing key generation flows
- Adds `tsc` build of web-app to makefile
- fixes existing typescript issues in web app, and some cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants