chore(sdk): Renames and moves chunker as seekable #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If these changes look good, signoff on them with: If they aren't any good, please remove them with: |
dmihalcik-virtru
force-pushed
the
feature/seekable
branch
from
10a1980 to
42cae41
Compare
I didn't rename chunker itself though. Seems unnecessary and will require more changes outside of the library. however, this is an excuse to move some code out of tdf3 into src, and unify it with the `DataSource` type, renamed to just `Source`, and add some helper/transformer methods.
dmihalcik-virtru
force-pushed
the
feature/seekable
branch
from
42cae41 to
36684b2
Compare
mkleene
approved these changes
Dec 13, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't rename chunker itself though. Seems unnecessary and will require more changes outside of the library. however, this is an excuse to move some code out of tdf3 into src, and unify it with the
DataSourcetype, renamed to justSource, and add some helper/transformer methods.