Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(sdk): New client object api #407

Merged
merged 6 commits into from
Dec 17, 2024
Merged

feat!(sdk): New client object api #407

merged 6 commits into from
Dec 17, 2024

Conversation

dmihalcik-virtru
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru commented Dec 13, 2024

  • Creates new type OpenTDF, which adds 'create' and 'read' methods for TDF objects
  • Sequesters old APIs into @opentdf/sdk/singlecontainer entry point. If the old API is desired, use this import, not @opentdf/sdk.

Copy link

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

@dmihalcik-virtru dmihalcik-virtru mentioned this pull request Dec 13, 2024
@dmihalcik-virtru dmihalcik-virtru changed the title Feature/api2 feat!(sdk): New client object api Dec 13, 2024
@dmihalcik-virtru dmihalcik-virtru marked this pull request as ready for review December 13, 2024 18:54
@dmihalcik-virtru dmihalcik-virtru requested a review from a team as a code owner December 13, 2024 18:54
Copy link

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

@dmihalcik-virtru dmihalcik-virtru force-pushed the feature/api2 branch 2 times, most recently from 193e020 to 51d3a39 Compare December 16, 2024 18:42
Copy link

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

Copy link

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

Copy link

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

- Creates new type `OpenTDF`, which adds 'create' and 'read' methods for TDF objects
- Sequesters old APIs into `@opentdf/sdk/singlecontainer` entry point. If the old API is desired, use this import, not `@opentdf/sdk`.
This reverts commit 8e698f2.
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
79.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@dmihalcik-virtru dmihalcik-virtru merged commit 40d963d into main Dec 17, 2024
11 of 12 checks passed
@dmihalcik-virtru dmihalcik-virtru deleted the feature/api2 branch December 17, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants