-
Notifications
You must be signed in to change notification settings - Fork 3
asdfs #637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
asdfs #637
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @el-virt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request represents an automated release of the web-sdk
's lib
component to its 1.0.0
major version. It integrates a substantial collection of new features, critical bug fixes, and internal improvements across the CLI, core SDK, and underlying libraries, enhancing functionality, stability, and maintainability.
Highlights
- Major Version Release: The
lib
component of theweb-sdk
has been officially released as version1.0.0
, signifying a stable and feature-rich milestone that consolidates numerous changes. - Enhanced CLI Functionality: The command-line interface gains new capabilities, including assertion signing key handling and verification, support for
--allowList
and--policyBinding ecdsa
options, and improved platform URL handling during decryption. - Core SDK and Library Improvements: Significant updates to the core SDK and underlying libraries include
kao.schemaVersion
, Key ID (KID) support in NanoTDF, enhanced ABAC configuration loading from policy services, and updated error types. - Expanded SDK Features: The SDK now includes an
OpenTDF.open
method, support for EC-wrapped keys, improved KAS integration (allowing fetching KASes from the platform), and a migration toconnect-rpc
calls for enhanced communication. - Comprehensive Bug Fixes and Stability: A wide array of bug fixes address issues ranging from regex efficiency and manifest size caps to NanoTDF policy binding, concurrency on rewrap, and various
npm audit
security updates, contributing to overall stability. - Dependency and Build System Updates: Key dependencies like
jose
have been updated to6.x
, the preferred Node.js version is now 22, and ESLint configurations have been refreshed, ensuring compatibility and improved code quality.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades the library version to 1.0.0. Ensure all dependent packages are compatible with this new version. Also, the keys in .github/release-please/release-please-manifest.json
could be ordered alphabetically.
lib/package-lock.json
Outdated
@@ -1,12 +1,12 @@ | |||
{ | |||
"name": "@opentdf/sdk", | |||
"version": "0.3.2", | |||
"version": "1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lib/package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@opentdf/sdk", | |||
"version": "0.3.2", | |||
"version": "1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
60255da
to
c92df6a
Compare
|
🤖 I have created a release beep boop
0.4.0 (2025-06-18)
Features
--policyBinding ecdsa
option (#352) (4e54c0d)Bug Fixes
This PR was generated with Release Please. See documentation.